> -----Original Message----- > From: Libc-alpha bounces+belagod=gcc.gnu.org@sourceware.org> On Behalf Of Tejas > Belagod via Libc-alpha > Sent: Thursday, June 30, 2022 4:26 PM > To: Florian Weimer > Cc: Szabolcs Nagy ; Tejas Belagod via Libc-alpha > ; Joseph Myers > Subject: RE: Reset HWCAP2_AFP bits in FPCR for default fenv. > > Thanks. > > Sorry, I intended the original mail body without the 'OK for master?' as the > commit message. I shall re-post the patch with the correct formatting. > I've attached the new patch with all the comments addressed. I hope I've done the right thing with the mail reply format and the patch attachment. Thanks, Tejas. > Thanks, > Tejas. > > > -----Original Message----- > > From: Florian Weimer > > Sent: Thursday, June 30, 2022 4:13 PM > > To: Tejas Belagod > > Cc: Joseph Myers ; Szabolcs Nagy > > ; Tejas Belagod via Libc-alpha > alpha@sourceware.org> > > Subject: Re: Reset HWCAP2_AFP bits in FPCR for default fenv. > > > > * Tejas Belagod: > > > > >> -----Original Message----- > > >> From: Joseph Myers > > >> Sent: Wednesday, June 29, 2022 10:24 PM > > >> To: Szabolcs Nagy > > >> Cc: Florian Weimer ; Tejas Belagod > > >> ; Tejas Belagod via Libc-alpha > >> alpha@sourceware.org> > > >> Subject: Re: Reset HWCAP2_AFP bits in FPCR for default fenv. > > >> > > >> On Wed, 29 Jun 2022, Szabolcs Nagy via Libc-alpha wrote: > > >> > > >> > i don't have a strong opinion, but i thought it made sense to > > >> > restore all these special bits with fesetenv(FE_DFL_ENV). > > >> > > >> Yes, I think FE_DFL_ENV (and FE_DFL_MODE) should cover all such > > >> architecture-specific control settings, even when we also don't > > >> support the use of most floating-point APIs with non-default values > > >> of > > those settings. > > >> > > > > > > Thanks all for your comments. > > > > > > Florian, given the explanations from Szabolcs and Joseph, do you > > > have any objections to this change? > > > > No objection to the change itself, but you didn't post the proposed > > commit message. Please mention “aarch64” in the subject. > > > > Thanks, > > Florian