From: Tejas Belagod <Tejas.Belagod@arm.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
Tejas Belagod via Libc-alpha <libc-alpha@sourceware.org>
Subject: RE: Reset HWCAP2_AFP bits in FPCR for default fenv.
Date: Thu, 30 Jun 2022 10:56:25 +0000 [thread overview]
Message-ID: <AS8PR08MB70795CB097C64474411A2C7BEABA9@AS8PR08MB7079.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <87r1361lg9.fsf@oldenburg.str.redhat.com>
Thanks.
Sorry, I intended the original mail body without the 'OK for master?' as the commit message. I shall re-post the patch with the correct formatting.
Thanks,
Tejas.
> -----Original Message-----
> From: Florian Weimer <fweimer@redhat.com>
> Sent: Thursday, June 30, 2022 4:13 PM
> To: Tejas Belagod <Tejas.Belagod@arm.com>
> Cc: Joseph Myers <joseph@codesourcery.com>; Szabolcs Nagy
> <Szabolcs.Nagy@arm.com>; Tejas Belagod via Libc-alpha <libc-
> alpha@sourceware.org>
> Subject: Re: Reset HWCAP2_AFP bits in FPCR for default fenv.
>
> * Tejas Belagod:
>
> >> -----Original Message-----
> >> From: Joseph Myers <joseph@codesourcery.com>
> >> Sent: Wednesday, June 29, 2022 10:24 PM
> >> To: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
> >> Cc: Florian Weimer <fweimer@redhat.com>; Tejas Belagod
> >> <Tejas.Belagod@arm.com>; Tejas Belagod via Libc-alpha <libc-
> >> alpha@sourceware.org>
> >> Subject: Re: Reset HWCAP2_AFP bits in FPCR for default fenv.
> >>
> >> On Wed, 29 Jun 2022, Szabolcs Nagy via Libc-alpha wrote:
> >>
> >> > i don't have a strong opinion, but i thought it made sense to
> >> > restore all these special bits with fesetenv(FE_DFL_ENV).
> >>
> >> Yes, I think FE_DFL_ENV (and FE_DFL_MODE) should cover all such
> >> architecture-specific control settings, even when we also don't
> >> support the use of most floating-point APIs with non-default values of
> those settings.
> >>
> >
> > Thanks all for your comments.
> >
> > Florian, given the explanations from Szabolcs and Joseph, do you have
> > any objections to this change?
>
> No objection to the change itself, but you didn't post the proposed commit
> message. Please mention “aarch64” in the subject.
>
> Thanks,
> Florian
next prev parent reply other threads:[~2022-06-30 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 9:34 Tejas Belagod
2022-06-29 9:54 ` Florian Weimer
2022-06-29 11:24 ` Szabolcs Nagy
2022-06-29 16:53 ` Joseph Myers
2022-06-30 10:19 ` Tejas Belagod
2022-06-30 10:42 ` Florian Weimer
2022-06-30 10:56 ` Tejas Belagod [this message]
2022-07-01 6:40 Tejas Belagod
2022-07-04 13:51 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR08MB70795CB097C64474411A2C7BEABA9@AS8PR08MB7079.eurprd08.prod.outlook.com \
--to=tejas.belagod@arm.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).