From: Sam James <sam@gentoo.org>
To: Fangrui Song <maskray@google.com>
Cc: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] Makerules: Generate shlib.lds with -fuse-ld=bfd
Date: Sun, 6 Nov 2022 23:15:59 +0000 [thread overview]
Message-ID: <B49D0D66-DFC8-4CD0-A178-F9B325D0FCC6@gentoo.org> (raw)
In-Reply-To: <20221106231516.ivgzfnk37qvecjf5@google.com>
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
> On 6 Nov 2022, at 23:15, Fangrui Song <maskray@google.com> wrote:
>
> On 2022-11-06, Sam James wrote:
>>
>>
>>> On 6 Nov 2022, at 23:06, Fangrui Song via Libc-alpha <libc-alpha@sourceware.org> wrote:
>>>
>>> On 2022-11-06, Sam James wrote:
>>>>
>>>>
>>>>> On 6 Nov 2022, at 18:17, Fangrui Song via Libc-alpha <libc-alpha@sourceware.org> wrote:
>>>>>
>>>>> lld does not dump a linker script with --verbose (it does not use a
>>>>> linker script driven design and lots of linker processing is not
>>>>> serializable as a linker script anyway). With the default
>>>>> --with-default-link=no build, $@T is empty and makes `test -s $@T` fail.
>>>>>
>>>>> Just dump the linker script with -fuse-ld=bfd. lld since 15
>>>>> (https://reviews.llvm.org/D124656) supports custom RELRO sections in the
>>>>> GNU ld dumped linker script.
>>>>> ---
>>>>
>>>> What if bfd isn't installed?
>>>
>>> Then --with-default-link=yes has to be used:)
>>
>> Configure should check in that case.
>
> The patch isn't worse than the current state: if ld => lld, the build
> will just fail due to `test -s $@T` (the linker script is empty).
Sure, but could you add a quick configure check while you're here?
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]
next prev parent reply other threads:[~2022-11-06 23:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 18:17 Fangrui Song
2022-11-06 21:21 ` Sam James
2022-11-06 23:06 ` Fangrui Song
2022-11-06 23:12 ` Sam James
2022-11-06 23:15 ` Fangrui Song
2022-11-06 23:15 ` Sam James [this message]
2022-11-06 23:21 ` Fangrui Song
2022-11-07 8:31 ` Florian Weimer
2022-11-08 0:06 ` Sam James
2022-11-08 0:22 ` Fangrui Song
2022-11-08 0:29 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B49D0D66-DFC8-4CD0-A178-F9B325D0FCC6@gentoo.org \
--to=sam@gentoo.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).