From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2088.outbound.protection.outlook.com [40.107.100.88]) by sourceware.org (Postfix) with ESMTPS id 60005386F00D for ; Mon, 11 Jan 2021 10:46:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60005386F00D ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KHvlurxy4nnwrNY1mTMRfbH2ODreKZGch76EOh4ayMYZYm8F1F6NgvMxz25NbSCAeP5EDcDxqlobYfRA4i3jXcOjnLxrLV5gY1Ard2OeUH8erwpYXxw4RsjRoDllLB0rLKrRmdPOGPpB6EG7gHI6zIu++SarWMdS9LohSWx4k2b+Gzfkf8I/zdY+imi1RYtuF+aa24lApx1sDWeEybtEK8KXut5eZdvmF1yqO8z1UAKv96maJQIj/CLiZvjBrJYpNRtiMkc4nDY7S51KEHXX1eaV8Zexuv+teDLySBdZZ9kskyMtSepsAmERXS6437Smhv3jyjdhLEAmbAlsLdeLAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ho1ynR3r4rzIXnUXVWrwGjUF9HU1hd4/UN5BaCmawGE=; b=Ve4zvhNkujtkxP9p9v858Qug6OF5siOxTXhdhnbV8IOBZ59XMRAfERBlbuJV7x3cRn6ic6tz6ahH6M+YxibarniAqZ5lroUjeHUQYpx95ivHXe8kX6dDGZYpU1vsG25SvilZ8F1TT08aTXIh+T9jThFEn72Y/b6/ujCgXMM0029/fapid4N+CE5L30Ee5D8ZWVo6jDhgR8Fa/J7xiyQXHTMTPHBmq4Z1ZMuftRdeUTq3zAtSqESFwj0fLRqDP4zD/DdeUt3hxHZ5wsDTmrdUstUtXPM9KItW0CLIy4XF2xA5gAogm/EJG725r6+rRk0HHcjJDLUUOfi9XWHlBIo0xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BN6PR1201MB0081.namprd12.prod.outlook.com (2603:10b6:405:4f::12) by BN6PR1201MB0082.namprd12.prod.outlook.com (2603:10b6:405:53::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.12; Mon, 11 Jan 2021 10:46:16 +0000 Received: from BN6PR1201MB0081.namprd12.prod.outlook.com ([fe80::20fa:a1a2:9e7d:1370]) by BN6PR1201MB0081.namprd12.prod.outlook.com ([fe80::20fa:a1a2:9e7d:1370%11]) with mapi id 15.20.3742.012; Mon, 11 Jan 2021 10:46:16 +0000 From: "Karumanchi, Sajan" To: Florian Weimer , sajan.karumanchi--- via Libc-alpha CC: "carlos@redhat.com" , "hjl.tools@gmail.com" , "Mallappa, Premachandra" Subject: RE: [PATCH] x86: Adding an upper bound for Enhanced REP MOVSB. Thread-Topic: [PATCH] x86: Adding an upper bound for Enhanced REP MOVSB. Thread-Index: AQHW5RFSltyoZ2Ulmk2Nwz9hjNE1Bqodw+//gAR/W6A= Date: Mon, 11 Jan 2021 10:46:16 +0000 Message-ID: References: <20210107162209.4047176-1-sajan.karumanchi@amd.com> <878s93v84g.fsf@oldenburg2.str.redhat.com> In-Reply-To: <878s93v84g.fsf@oldenburg2.str.redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2021-01-11T10:45:42Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=56adf8c4-3784-486e-9de5-0000762718dd; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_enabled: true msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_setdate: 2021-01-11T10:46:13Z msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_method: Privileged msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_name: Public_0 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_actionid: b6edb43a-d191-4b33-a75e-0000e79fa850 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_contentbits: 0 dlp-product: dlpe-windows dlp-version: 11.5.0.60 dlp-reaction: no-action x-originating-ip: [106.51.111.18] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 009bb3ab-9756-4be0-f47c-08d8b61e1f51 x-ms-traffictypediagnostic: BN6PR1201MB0082: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fm63NJTm26xXLyVPhpn/tZ/mmJEf4yioHqhS4kl0lwo+l2Y5OEh86brzhMmKGKrCls1B8g6SYoRYkrGMAhG9gKRdV3B13jOKf/lSmcxwnqJAeW0vEFzhgFV3nMg3w2xdd+QR/5yPUTQy9Mz1xBI4QdNwe43Pxh4MB9H19AeyHown61SWeW0+JNDKZIHIMKHvqHYzUSIcDgCqID8EY1Haj2HDPcHVs1hildxeK5l+fD9XtvzoFKswrxalhHHRnxhj+7Acxya1iOvkwiG45fy9Kb4a982cDsodWfXmW3YJylarQ4u71ype8fDeGJCWR0UE0Cd395o/u04z1eYJ/i7GY3qD9K1I5qVhrr3UzK9AKHg5Oc1lgGo4jaJTi/QI1r+XtpRNLXgTltU+2feTGWH/mGBhWRz3yhB1Pnnnq/6RNwPglzHuHih0++5WCXxdZSoURjWHVxm/Gg50YQ6JJl0TWQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1201MB0081.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(136003)(39860400002)(366004)(4326008)(76116006)(66476007)(66946007)(66446008)(64756008)(66556008)(83380400001)(55016002)(186003)(5660300002)(52536014)(45080400002)(33656002)(9686003)(966005)(2906002)(71200400001)(8936002)(55236004)(54906003)(8676002)(6506007)(53546011)(110136005)(26005)(316002)(7696005)(86362001)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?83u9xwriNmf6yNzYu3DzrawncGfDOlSXOnRhBWomx0qRWtK8qq+nMaKehbUt?= =?us-ascii?Q?OfqYb8Z7Lwva80/KzOMe70Z0Qy59nkv65sUk4WVnnIfAcMc1Rvaks7ArC6Rj?= =?us-ascii?Q?gmetAQGs9+YwXTtcOjhcl5r7JoH28wkBFUC4Zn6F9Whz7JHZiU2pQbxbAhH6?= =?us-ascii?Q?6gAP42fBqo5wtCGV6f78v98yrBvPYfYv+D2B6nEVb0la1UkqqEpZFb3n87bx?= =?us-ascii?Q?4yLtZkj2d7I6igVxjsqjFhBbuzxePtzvaD0MWawLWeqxH99FIutzkuDmZj14?= =?us-ascii?Q?TttzLuqiJIKlcwbZ6rUDy0SFdSBD8e4s8fBqFj0V/lhf+kvt8A01qojzodZZ?= =?us-ascii?Q?71d1HnIdeKzrLKG3Ow/NjJ4KuKLnnBwSZ27BTx/94/3A8d+C9IdrUWWAbnoi?= =?us-ascii?Q?YkQswfuTXPyQs/luuXI91q2ztH79ffARVkfp9as2CPKjir89FrayYm/5KEtD?= =?us-ascii?Q?tvhdJDFIpAeIDGnh4YuN2z7grZA356AWszNySOUvPlBf5zDEP8C4JOFpbqJi?= =?us-ascii?Q?agkgbwMS2KHwd7h6EJt71cLrqNS6bLSRasX+7TUKxdUhuqGlc/fvO85bMJmi?= =?us-ascii?Q?AaVawMnNWp1JmnDzlpkJs7o7Bipunc6OUKPajqHSfOdVFEVXSbsf2RnuGZYA?= =?us-ascii?Q?wHDo/rsmpeyR9KQ/UrKYjkOAhNMTfnbYt8n4Ex3sEi9etEFTld5svHNus7Bk?= =?us-ascii?Q?yY47DgNN4PcG91sJuk1jAsT2SR/ZC6oQRfaIFi9tsNje4dNYibU6n8Jteijf?= =?us-ascii?Q?e44fFqGK256y2QfVE9Qkxi5v6XuV8daj8bBtqjTCHnLuuXug39b2cNXu+/Pa?= =?us-ascii?Q?UQFG+HCdSjvsqAJPLE1+W7jH0h23pEnBU6qGFLGp/AJlPn39vbZEaCbIdiAh?= =?us-ascii?Q?UfJNJiylgIviE7x8HA/pHkDtA9NhbOLfLHHe8pmLnSmSq7aElQLMEifJybz0?= =?us-ascii?Q?XH/ALKnrYK/Seu/MzYTtRWHPwtcpT/R52MtXGF2d+C0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR1201MB0081.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 009bb3ab-9756-4be0-f47c-08d8b61e1f51 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2021 10:46:16.1934 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NGEK+x8Afvv7GpvpDkLrHg+G64vA5B3vh9ymgPG59bnX67kRvIwuCLXj8LD5yT2+hYj4r3ybKI/ZMYgFsfXM1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0082 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 10:46:18 -0000 [AMD Public Use] Hi Florian, I have pushed a new patch on top the rebased master branch. Thanks & Regards, Sajan K. -----Original Message----- From: Florian Weimer =20 Sent: Friday, January 8, 2021 7:33 PM To: sajan.karumanchi--- via Libc-alpha Cc: carlos@redhat.com; hjl.tools@gmail.com; Karumanchi, Sajan ; Mallappa, Premachandra Subject: Re: [PATCH] x86: Adding an upper bound for Enhanced REP MOVSB. [CAUTION: External Email] * sajan karumanchi: > From: Sajan Karumanchi > > In the process of optimizing memcpy for AMD machines, we have found=20 > the vector move operations are outperforming enhanced REP MOVSB for=20 > data transfers above the L2 cache size on Zen3 architectures. > To handle this use case, we are adding an upper bound parameter on=20 > enhanced REP MOVSB:'__x86_max_rep_movsb_threshold'. > As per large-bench results, we are configuring this parameter to the > L2 cache size for AMD machines and applicable from Zen3 architecture=20 > supporting the ERMS feature. > For architectures other than AMD, it is the computed value of=20 > non-temporal threshold parameter. > > Reviewed-by: Premachandra Mallappa Thanks for the patch. Would you be able to rebase it on top of current mas= ter? There are some non-trivial conflicts, as far as I can see. Florian -- Red Hat GmbH, https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3= A%2F%2Fde.redhat.com%2F&data=3D04%7C01%7Csajan.karumanchi%40amd.com%7C3= 85bb220a2ed40f8383b08d8b3de2881%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%= 7C637457114064957358%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2= luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3Do3x1r6WGqvzGwx1Rju%= 2FEyksBPRJGb%2B3cx9c%2FJHnP%2B3k%3D&reserved=3D0 , Registered seat: Gra= sbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Dir= ectors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill