* [PATCH] inet: add uint64_t accessors to in6_addr union
@ 2017-11-12 6:56 Shawn Landden
2017-11-12 7:27 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Landden @ 2017-11-12 6:56 UTC (permalink / raw)
To: libc-alpha; +Cc: Shawn Landden
64-bit architectures are common so this makes sense to have.
64-bit arches were not so common 1997-02-16.
Signed-off-by: Shawn Landden <slandden@gmail.com>
---
inet/netinet/in.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/inet/netinet/in.h b/inet/netinet/in.h
index f94b4b4e1c..72d5dec312 100644
--- a/inet/netinet/in.h
+++ b/inet/netinet/in.h
@@ -215,11 +215,13 @@ struct in6_addr
uint8_t __u6_addr8[16];
uint16_t __u6_addr16[8];
uint32_t __u6_addr32[4];
+ uint64_t __u6_addr64[2];
} __in6_u;
#define s6_addr __in6_u.__u6_addr8
#ifdef __USE_MISC
# define s6_addr16 __in6_u.__u6_addr16
# define s6_addr32 __in6_u.__u6_addr32
+# define s6_addr64 __in6_u.__u6_addr64
#endif
};
#endif /* !__USE_KERNEL_IPV6_DEFS */
--
2.15.0.rc2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] inet: add uint64_t accessors to in6_addr union
2017-11-12 6:56 [PATCH] inet: add uint64_t accessors to in6_addr union Shawn Landden
@ 2017-11-12 7:27 ` Florian Weimer
[not found] ` <CA+49okotoe+0VvCU0EJb19yWnV=VXrsSSSDkX4PexvKuZij3ew@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2017-11-12 7:27 UTC (permalink / raw)
To: Shawn Landden; +Cc: libc-alpha
* Shawn Landden:
> diff --git a/inet/netinet/in.h b/inet/netinet/in.h
> index f94b4b4e1c..72d5dec312 100644
> --- a/inet/netinet/in.h
> +++ b/inet/netinet/in.h
> @@ -215,11 +215,13 @@ struct in6_addr
> uint8_t __u6_addr8[16];
> uint16_t __u6_addr16[8];
> uint32_t __u6_addr32[4];
> + uint64_t __u6_addr64[2];
> } __in6_u;
I believe this breaks ABI because it changes the alignment of struct
in6_addr.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] inet: add uint64_t accessors to in6_addr union
[not found] ` <CA+49okoai7OHhtHkMAUoBBDq_howuLb7m1T5xUz15C7S7-oxhg@mail.gmail.com>
@ 2017-11-12 11:03 ` Shawn Landden
0 siblings, 0 replies; 3+ messages in thread
From: Shawn Landden @ 2017-11-12 11:03 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
On Nov 11, 2017 23:27, "Florian Weimer" <fw@deneb.enyo.de> wrote:
* Shawn Landden:
> diff --git a/inet/netinet/in.h b/inet/netinet/in.h
> index f94b4b4e1c..72d5dec312 100644
> --- a/inet/netinet/in.h
> +++ b/inet/netinet/in.h
> @@ -215,11 +215,13 @@ struct in6_addr
> uint8_t __u6_addr8[16];
> uint16_t __u6_addr16[8];
> uint32_t __u6_addr32[4];
> + uint64_t __u6_addr64[2];
> } __in6_u;
I believe this breaks ABI because it changes the alignment of struct
in6_addr.
Oh my bad. I think you are right, as it would have been 32-bit aligned.
[-- Attachment #2: Type: text/html, Size: 1014 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-12 11:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-12 6:56 [PATCH] inet: add uint64_t accessors to in6_addr union Shawn Landden
2017-11-12 7:27 ` Florian Weimer
[not found] ` <CA+49okotoe+0VvCU0EJb19yWnV=VXrsSSSDkX4PexvKuZij3ew@mail.gmail.com>
[not found] ` <CA+49okoai7OHhtHkMAUoBBDq_howuLb7m1T5xUz15C7S7-oxhg@mail.gmail.com>
2017-11-12 11:03 ` Shawn Landden
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).