From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1720 invoked by alias); 28 Oct 2014 20:18:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 1711 invoked by uid 89); 28 Oct 2014 20:18:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-la0-f47.google.com MIME-Version: 1.0 X-Received: by 10.152.8.100 with SMTP id q4mr6485664laa.48.1414527491410; Tue, 28 Oct 2014 13:18:11 -0700 (PDT) In-Reply-To: <20141028201613.GE13832@vapier.wh0rd.info> References: <1414396793-9005-1-git-send-email-apinski@cavium.com> <1414396793-9005-17-git-send-email-apinski@cavium.com> <20141028201613.GE13832@vapier.wh0rd.info> Date: Tue, 28 Oct 2014 20:18:00 -0000 Message-ID: Subject: Re: [PATCH 16/29] [AARCH64] Detect ILP32 in configure scripts. From: Andrew Pinski To: Andrew Pinski , GNU C Library Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-10/txt/msg00670.txt.bz2 On Tue, Oct 28, 2014 at 1:16 PM, Mike Frysinger wrote: > On 27 Oct 2014 00:59, Andrew Pinski wrote: >> --- a/sysdeps/unix/sysv/linux/aarch64/configure.ac >> +++ b/sysdeps/unix/sysv/linux/aarch64/configure.ac >> @@ -1,6 +1,11 @@ >> GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory. >> # Local configure fragment for sysdeps/unix/sysv/linux/aarch64. >> >> -arch_minimum_kernel=3.7.0 >> +if test $aarch64_config_abi = ilp32; then >> + arch_minimum_kernel=3.19.0 >> + LIBC_SLIBDIR_RTLDDIR([libilp32], [lib]) > > "libilp32" is pretty ugly. why not something simpler ? MIPS n32 uses "lib32" > (since o32 is "lib" and n64 is "lib64"). seems reasonable to also use "lib32" > here and make the next 32bit ABI pick an uglier name. I had used lib32 but the maintainers had asked to move it over to libilp32 when I submitted the GCC patches: https://gcc.gnu.org/ml/gcc-patches/2013-12/msg00282.html Thanks, Andrew Pinski > -mike