public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Zong Li <zongbox@gmail.com>
To: fweimer@redhat.com, joseph@codesourcery.com
Cc: Zong Li <zong@andestech.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so
Date: Wed, 24 Oct 2018 15:59:00 -0000	[thread overview]
Message-ID: <CA+ZOyahi5LA=n2oHV=A568_CHAuttjOu4HCTTwTmFv7QFvdWXg@mail.gmail.com> (raw)
In-Reply-To: <87zhv362a0.fsf@oldenburg.str.redhat.com>

Florian Weimer <fweimer@redhat.com> 於 2018年10月24日 週三 下午6:56寫道：
>
> * Zong Li:
>
> > The Makefile variable name loses the file extension (.so). It causes
> > the linker option not applies to the corresponding file that it's
> > file name matchs with the variable without LDFLAGS- prefix.
> >
> >       * elf/Makefile (LDFLAGS-tst-execstack-mod): Change variable name by
> >       adding the file extension (.so).
>
> This looks okay to me.  Can you commit this yourself, or do you need
> someone who commits it for you?
>

No, I can't commit it by myself.

  reply	other threads:[~2018-10-24 13:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 10:15 Zong Li
2018-07-25 18:54 ` Vineet Gupta
2018-07-25 20:22   ` Joseph Myers
2018-07-25 20:54     ` Vineet Gupta
2018-07-25 20:56       ` Joseph Myers
2018-07-26  1:19         ` Zong Li
2018-07-26 15:01           ` Joseph Myers
2018-10-15 12:43             ` Zong Li
2018-10-15 13:53               ` Joseph Myers
2018-10-15 17:01 ` Zong Li
2018-10-24 11:01 ` Florian Weimer
2018-10-24 15:59   ` Zong Li [this message]
2018-10-25 12:22     ` Florian Weimer
  -- strict thread matches above, loose matches on Subject: below --
2018-07-12  8:19 Zong Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+ZOyahi5LA=n2oHV=A568_CHAuttjOu4HCTTwTmFv7QFvdWXg@mail.gmail.com' \
    --to=zongbox@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=zong@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).