From: Zong Li <zongbox@gmail.com>
To: rth@twiddle.net
Cc: Zong Li <zong@andestech.com>,
joseph@codesourcery.com, libc-alpha@sourceware.org,
Palmer Dabbelt <palmer@dabbelt.com>,
darius@bluespec.com, Andrew Waterman <andrew@sifive.com>,
dj@redhat.com
Subject: Re: [PATCH 6/9] RISC-V: Split the soft-fp into rv32 and rv64
Date: Fri, 13 Jul 2018 13:19:00 -0000 [thread overview]
Message-ID: <CA+ZOyajgtrZu3djXgP1PLozLw+QSzLyR=3qyRC5AR5v7REffFg@mail.gmail.com> (raw)
In-Reply-To: <cbe3e025-b276-3e10-2c67-2995873a6aa2@twiddle.net>
Richard Henderson <rth@twiddle.net> 於 2018年7月13日 週五 下午6:34寫道：
>
> On 07/12/2018 08:00 PM, Zong Li wrote:
> > This is the problem I encountered, In _FP_FMA (fs, wc, dwc, R, X, Y, Z),
> > it will use the _FP_FRAC_HIGHBIT_DW_##dwc macro, and it will be expanded to
> > _FP_FRAC_HIGHBIT_DW_8, but the _FP_FRAC_HIGHBIT_DW_8 is not be
> > implemented in soft-fp/op-8.h, there is only _FP_FRAC_HIGHBIT_DW_1,
> > _FP_FRAC_HIGHBIT_DW_2 and _FP_FRAC_HIGHBIT_DW_4 in the soft-fp/op-*.h.
> >
> > I cannot find another 32 bit port has this issue, because they use the ldbl-128.
>
> It appears that the code has bitrotted somewhat because of non-use.
>
> Also, _FP_FRAC_HIGHBIT_DW_[1234] is a macro that should not exist,
> because it has an identical definition in each case. But in the
> meantime, just copy any of the other (identical) definitions into
> op-8.h.
>
> The other levels of macro nesting to which this expands does exist.
> At least as far as I can track it by eye. ;-)
>
>
> r~
Thanks for your reply. So shall I need to submit a patch for adding
these definition of
macros first?
next prev parent reply other threads:[~2018-07-13 13:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 10:27 [PATCH 0/9] RISC-V glibc port for the 32 bit Zong Li
2018-07-12 10:27 ` [PATCH 3/9] RISC-V: Add path of library directories " Zong Li
2018-07-12 10:27 ` [PATCH 6/9] RISC-V: Split the soft-fp into rv32 and rv64 Zong Li
2018-07-12 17:46 ` Richard Henderson
2018-07-13 1:00 ` Zong Li
2018-07-13 10:34 ` Richard Henderson
2018-07-13 13:19 ` Zong Li [this message]
2018-07-13 13:49 ` Richard Henderson
2018-07-13 13:55 ` Zong Li
2018-07-12 10:27 ` [PATCH 2/9] RISC-V: Add dynamic loader for the 32 bit Zong Li
2018-07-12 10:27 ` [PATCH 4/9] RISC-V: The ABI implementation for the 32-bit Zong Li
2018-07-12 10:27 ` [PATCH 1/9] Documentation for the 32 bit RISC-V port Zong Li
2018-07-12 10:27 ` [PATCH 8/9] RISC-V: Build Infastructure for the 32 bit Zong Li
2018-07-12 10:27 ` [PATCH 9/9] Add 32 bit RISC-V to build-many-glibcs.py Zong Li
2018-07-12 10:27 ` [PATCH 5/9] RISC-V: Hard float support for the 32 bit Zong Li
2018-07-12 10:28 ` [PATCH 7/9] RISC-V: Add ABI lists Zong Li
2018-07-31 18:49 ` [PATCH 0/9] RISC-V glibc port for the 32 bit Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+ZOyajgtrZu3djXgP1PLozLw+QSzLyR=3qyRC5AR5v7REffFg@mail.gmail.com' \
--to=zongbox@gmail.com \
--cc=andrew@sifive.com \
--cc=darius@bluespec.com \
--cc=dj@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=palmer@dabbelt.com \
--cc=rth@twiddle.net \
--cc=zong@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).