From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-94261-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 38409 invoked by alias); 13 Jul 2018 13:19:30 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 38400 invoked by uid 89); 13 Jul 2018 13:19:30 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=2.6 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FROM,GARBLED_BODY,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy==b1=e4=ba, 20187, 2018=e5=b9=b47=e6, H*Ad:U*andrew?=
X-HELO: mail-io0-f195.google.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=XPHG7q7nfybpu8h4aAih8U3m6iO2nJ6vqxJyk67UAW8=;
        b=MAXsk0wfUmy0LGSp7yC6BmU3UaiZ3Ydl7zOw4SU7kAyZ56tJQ6iK7k70YeDr7fOHZt
         vanq2M6Z/OSA2acwc1BlhUJuU6LoXLK+J5+ReXAo5INWwh2xfNVfCn0NHxGbFZP66W/8
         n+J3IF0gOK6Dsytz72kimvEPkilqITI00KWFtfmd1wwl/0ia9E3sdFymYSbWmGcyq8eM
         tp9S23kLu44ktpQP47DgNfGBfOqhNha+hC8xW1+5nB4rWhLSloiEKG3llFZ0HSsHq7Fv
         2bX+WghauN75dSqjJ7xXAWasnZfVNQwm9MidUXKRVBznTeFoW9tvlo7AhMuBGG+KIj7Y
         wT8Q==
MIME-Version: 1.0
References: <cover.1531384753.git.zong@andestech.com> <7556c9af67290455145fd92e621439c7cc2e8f48.1531384754.git.zong@andestech.com>
 <21154f07-dc84-015f-e958-c8505a9dfbc5@twiddle.net> <CA+ZOyahXL7ZXwdFkQZBa6Dn8BN1Z--Ug7svWTCBDyzU0djZvRQ@mail.gmail.com>
 <cbe3e025-b276-3e10-2c67-2995873a6aa2@twiddle.net>
In-Reply-To: <cbe3e025-b276-3e10-2c67-2995873a6aa2@twiddle.net>
From: Zong Li <zongbox@gmail.com>
Date: Fri, 13 Jul 2018 13:19:00 -0000
Message-ID: <CA+ZOyajgtrZu3djXgP1PLozLw+QSzLyR=3qyRC5AR5v7REffFg@mail.gmail.com>
Subject: Re: [PATCH 6/9] RISC-V: Split the soft-fp into rv32 and rv64
To: rth@twiddle.net
Cc: Zong Li <zong@andestech.com>, joseph@codesourcery.com, libc-alpha@sourceware.org, 
	Palmer Dabbelt <palmer@dabbelt.com>, darius@bluespec.com, 
	Andrew Waterman <andrew@sifive.com>, dj@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2018-07/txt/msg00376.txt.bz2

Richard Henderson <rth@twiddle.net> =E6=96=BC 2018=E5=B9=B47=E6=9C=8813=E6=
=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=886:34=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On 07/12/2018 08:00 PM, Zong Li wrote:
> > This is the problem I encountered, In  _FP_FMA (fs, wc, dwc, R, X, Y, Z=
),
> > it will use the _FP_FRAC_HIGHBIT_DW_##dwc macro, and it will be expande=
d to
> >  _FP_FRAC_HIGHBIT_DW_8, but the _FP_FRAC_HIGHBIT_DW_8 is not be
> > implemented in soft-fp/op-8.h, there is only _FP_FRAC_HIGHBIT_DW_1,
> > _FP_FRAC_HIGHBIT_DW_2 and _FP_FRAC_HIGHBIT_DW_4 in the soft-fp/op-*.h.
> >
> > I cannot find another 32 bit port has this issue, because they use the =
ldbl-128.
>
> It appears that the code has bitrotted somewhat because of non-use.
>
> Also, _FP_FRAC_HIGHBIT_DW_[1234] is a macro that should not exist,
> because it has an identical definition in each case.  But in the
> meantime, just copy any of the other (identical) definitions into
> op-8.h.
>
> The other levels of macro nesting to which this expands does exist.
> At least as far as I can track it by eye.  ;-)
>
>
> r~

Thanks for your reply. So shall I need to submit a patch for adding
these definition of
macros first?