From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id EF3823857C69 for ; Mon, 24 May 2021 01:39:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EF3823857C69 Received: by mail-qk1-x730.google.com with SMTP id i5so18407695qkf.12 for ; Sun, 23 May 2021 18:39:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9oJecrpxMuqM8wB/z75Rys4aM+Nmddle2EI8Rkzt1Ss=; b=lDAbvsQfmX7pL9H+263DGUtI3VC++yVBdXq5u/MMUawZW3jy457wjK2hZ54jfuDPMP iSNXBHsgyms6+6Eea2FFURzYW7OD1+Cz2tU8L6mjiyUVUEqc8dO4ZVE50sv+SpoUWNMw antAVtWWaAy+48mNWytrlRt2P1RT8odFZbn8cynmI44YTmticBuReC0LKRVTBhaENBVy y1uF4CYubeKZjgK0yLC8QzGqCmIvo3O5VXKeEnp8k3/tuLA3HiVfJwTto8UEQ3sdTecC O+gnK8eNW4Urd6EASIp28tH4dV4VcdCiwhd9lq/C3ocpBO0SX6Ufq5Su/Gg1JNmMSUHC MStw== X-Gm-Message-State: AOAM5339QKFrLODxvEC6qkj94WCgRFZwwP/k4gYRhxd5s/pssSoB7UuW FW2bqXFSXXw4NvXkLNAupIHEOzvKpBctcCEgJ0vNqlSg3i+kvQ== X-Google-Smtp-Source: ABdhPJz5xMcrTS6wjXp/OVSZoy9LwnCACBANon803NSMl8CgwsGhrBYGlKjOp1bIl0WLhiZJB1o4yMS2wbmH6sMYups= X-Received: by 2002:a05:620a:8d6:: with SMTP id z22mr26499008qkz.407.1621820378522; Sun, 23 May 2021 18:39:38 -0700 (PDT) MIME-Version: 1.0 References: <20210522002227.2234377-1-ibmibmibm.tw@gmail.com> In-Reply-To: From: =?UTF-8?B?6Kyd5piH6YGUKFNoZW4tVGEgSHNpZWgp?= Date: Mon, 24 May 2021 09:39:27 +0800 Message-ID: Subject: Re: [PATCH v6 1/3] math: redirect roundeven function To: "H.J. Lu" Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 May 2021 01:39:40 -0000 I don't know if it is not needed, but I saw the same line at "sysdeps/ieee754/ldbl-96/s_roundl.c", which is added by this commit: https://sourceware.org/git/?p=3Dglibc.git;a=3Dcommit;h=3D9755bc4686d8cd6a0e= 9539040b903e9e9291c319 H.J. Lu =E6=96=BC 2021=E5=B9=B45=E6=9C=8824=E6=97=A5 = =E9=80=B1=E4=B8=80 =E4=B8=8A=E5=8D=882:55=E5=AF=AB=E9=81=93=EF=BC=9A > > On Fri, May 21, 2021 at 5:23 PM Shen-Ta Hsieh wr= ote: > > > > This patch redirect roundeven function for futhermore changes. > > > > Signed-off-by: Shen-Ta Hsieh > > --- > > include/math.h | 2 +- > > sysdeps/ieee754/dbl-64/s_roundeven.c | 4 +++- > > sysdeps/ieee754/float128/s_roundevenf128.c | 1 + > > sysdeps/ieee754/flt-32/s_roundevenf.c | 3 +++ > > sysdeps/ieee754/ldbl-128/s_roundevenl.c | 1 + > > sysdeps/ieee754/ldbl-96/s_roundevenl.c | 1 + > > 6 files changed, 10 insertions(+), 2 deletions(-) > > > > diff --git a/include/math.h b/include/math.h > > index e1c2a4eb64..b4772d3d3b 100644 > > --- a/include/math.h > > +++ b/include/math.h > > @@ -38,7 +38,6 @@ libm_hidden_proto (__issignaling) > > libm_hidden_proto (__issignalingf) > > libm_hidden_proto (__exp) > > libm_hidden_proto (__expf) > > -libm_hidden_proto (__roundeven) > > > > # if !defined __NO_LONG_DOUBLE_MATH \ > > && __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI =3D=3D 0 > > @@ -159,6 +158,7 @@ fabsf128 (_Float128 x) > > MATH_REDIRECT (sqrt, "__ieee754_", MATH_REDIRECT_UNARY_ARGS) > > MATH_REDIRECT (ceil, "__", MATH_REDIRECT_UNARY_ARGS) > > MATH_REDIRECT (floor, "__", MATH_REDIRECT_UNARY_ARGS) > > +MATH_REDIRECT (roundeven, "__", MATH_REDIRECT_UNARY_ARGS) > > MATH_REDIRECT (rint, "__", MATH_REDIRECT_UNARY_ARGS) > > MATH_REDIRECT (trunc, "__", MATH_REDIRECT_UNARY_ARGS) > > MATH_REDIRECT (round, "__", MATH_REDIRECT_UNARY_ARGS) > > diff --git a/sysdeps/ieee754/dbl-64/s_roundeven.c b/sysdeps/ieee754/dbl= -64/s_roundeven.c > > index 943b2c634c..5deff3bb8a 100644 > > --- a/sysdeps/ieee754/dbl-64/s_roundeven.c > > +++ b/sysdeps/ieee754/dbl-64/s_roundeven.c > > @@ -16,6 +16,7 @@ > > License along with the GNU C Library; if not, see > > . */ > > > > +#define NO_MATH_REDIRECT > > #include > > #include > > #include > > @@ -66,5 +67,6 @@ __roundeven (double x) > > INSERT_WORDS64 (x, ix); > > return x; > > } > > -hidden_def (__roundeven) > > +#ifndef __roundeven > > libm_alias_double (__roundeven, roundeven) > > +#endif > > diff --git a/sysdeps/ieee754/float128/s_roundevenf128.c b/sysdeps/ieee7= 54/float128/s_roundevenf128.c > > index 5a9b3f395f..e0faf727f6 100644 > > --- a/sysdeps/ieee754/float128/s_roundevenf128.c > > +++ b/sysdeps/ieee754/float128/s_roundevenf128.c > > @@ -1,2 +1,3 @@ > > +#define NO_MATH_REDIRECT > > #include > > #include "../ldbl-128/s_roundevenl.c" > > diff --git a/sysdeps/ieee754/flt-32/s_roundevenf.c b/sysdeps/ieee754/fl= t-32/s_roundevenf.c > > index ae54365bbe..2cc0d7b001 100644 > > --- a/sysdeps/ieee754/flt-32/s_roundevenf.c > > +++ b/sysdeps/ieee754/flt-32/s_roundevenf.c > > @@ -17,6 +17,7 @@ > > License along with the GNU C Library; if not, see > > . */ > > > > +#define NO_MATH_REDIRECT > > #include > > #include > > #include > > @@ -67,4 +68,6 @@ __roundevenf (float x) > > SET_FLOAT_WORD (x, ix); > > return x; > > } > > +#ifndef __roundevenf > > libm_alias_float (__roundeven, roundeven) > > +#endif > > diff --git a/sysdeps/ieee754/ldbl-128/s_roundevenl.c b/sysdeps/ieee754/= ldbl-128/s_roundevenl.c > > index 02765be0e0..7c9c11fad2 100644 > > --- a/sysdeps/ieee754/ldbl-128/s_roundevenl.c > > +++ b/sysdeps/ieee754/ldbl-128/s_roundevenl.c > > @@ -17,6 +17,7 @@ > > License along with the GNU C Library; if not, see > > . */ > > > > +#define NO_MATH_REDIRECT > > Is this really needed? > > > #include > > #include > > #include > > diff --git a/sysdeps/ieee754/ldbl-96/s_roundevenl.c b/sysdeps/ieee754/l= dbl-96/s_roundevenl.c > > index 8340116ed8..f826829c31 100644 > > --- a/sysdeps/ieee754/ldbl-96/s_roundevenl.c > > +++ b/sysdeps/ieee754/ldbl-96/s_roundevenl.c > > @@ -17,6 +17,7 @@ > > License along with the GNU C Library; if not, see > > . */ > > > > +#define NO_MATH_REDIRECT > > Is this really needed? > > > #include > > #include > > #include > > -- > > 2.31.1 > > > > > -- > H.J.