From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-54836-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 28204 invoked by alias); 27 Nov 2014 09:06:31 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 28194 invoked by uid 89); 27 Nov 2014 09:06:30 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-wg0-f44.google.com
MIME-Version: 1.0
X-Received: by 10.180.75.237 with SMTP id f13mr48424906wiw.69.1417079184795;
 Thu, 27 Nov 2014 01:06:24 -0800 (PST)
In-Reply-To: <m56n27$lv4$1@ger.gmane.org>
References: <alpine.DEB.2.10.1411261900020.854@digraph.polyomino.org.uk>
	<m56n27$lv4$1@ger.gmane.org>
Date: Thu, 27 Nov 2014 09:06:00 -0000
Message-ID: <CAAHN_R0pfQ3LXUqFCmJKkZHvL5XLENJcWsnre4rupZOMcAfC_A@mail.gmail.com>
Subject: Re: Avoid warnings for unused results in nscd/connections.c
From: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com>
To: Stefan Liebler <stli@linux.vnet.ibm.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2014-11/txt/msg00810.txt.bz2

On 27 November 2014 at 13:53, Stefan Liebler <stli@linux.vnet.ibm.com> wrot=
e:
> Building glibc fails at least on s390/power with:
> connections.c: In function =E2=80=98restart=E2=80=99:
> connections.c:1467:4: error: implicit declaration of function =E2=80=98ig=
nore_value=E2=80=99
> [-Werror=3Dimplicit-function-declaration]
>     ignore_value (setuid (server_uid));
>     ^
> cc1: some warnings being treated as errors
>
> Including libc-internal.h fixes the build failure.
>
> Bye
> Stefan
>
> ---
> 2014-11-27  Stefan Liebler  <stli@linux.vnet.ibm.com>
>
>         * nscd/connections.c: Include libc-internal.h
>           because of macro usage ignore_value.

libc-internal.h got included indirectly on x86_64 (via
sysdeps/x86_64/tls.h), which is why it worked there and not on other
architectures.  This fix is correct, please commit it.

Siddhesh
--=20
http://siddhesh.in