Re: [PATCH] math: Add more details to the test driver output.

[Joe Simmons-Talbott <josimmon@redhat.com>]

On Thu, May 16, 2024 at 12:46 PM Joseph Myers <josmyers@redhat.com> wrote:
>
> On Wed, 8 May 2024, Joe Simmons-Talbott wrote:
>
> > +#define TEST_INPUT 1
> > +#define TEST_BUILTIN 2
> > +static int noErrors;    /* number of errors */
> > +static int noTests;     /* number of tests (without testing exceptions) */
> > +static int noBuiltinTests; /* number of builtin tests  */
>
> The concept of "builtin" tests seems obscure; there are lots of things it
> could mean.  It doesn't refer to tests for built-in functions; it doesn't
> refer to all the auxiliary tests for exceptiosn and errno that are run as
> part of testing a given input value.  So I think the comment needs to
> explain what's meant by a builtin test (or, even better, find a name that
> makes it clearer, and use that name in the output that refers to the
> number of such tests as well as in variable / macro naming).
>
> --
> Joseph S. Myers
> josmyers@redhat.com
>

Thank you for your review. I agree that "builtin" is probably not the
best option.  I'm working on a v2 patch that uses "maxerror" instead
since that is what is being counted here.

Thanks,
Joe

-- 
Joe Simmons-Talbott