From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 971613858D34 for ; Wed, 27 Mar 2024 18:45:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 971613858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 971613858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711565154; cv=none; b=YsyKZZfO02TsJydHBNYzzd8J7aoCFipEH8aIhpi8qkpSh2miK2BgpySPWh2aGMJ0vKKWFtrkMKWZukpazs4r54as8DiGY9prq3KW5FGQCdZbYb1KoyMXFrKMIJrD2ET7IDBuiBgEpzl2EV+kJEoqw5PWVt2Is/eqWW07lvs1qX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711565154; c=relaxed/simple; bh=mQ7vFjUrl0UP0LAyrIpoktZ5r2qDZNco93XpaFC+m4s=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ofv4HkLVxNNqUYqjITuxDxOvFGQYkCydTBiZaYyl0H/fwtKd1AFY7ILmt2xShFgEWzeNYIhjn05aEikS6IHLxov8bhup2T4tMv6l/dLS1JhsWYb42M2pcUbtirrnxiN8cXRjHpi29LpSujNUcXWHcb5IYMWJIKqrvShlgJ773G4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711565151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SwrxKD/873ovZB9okVvIeRPiM2lgQozGPeLRLoYV9I8=; b=eq7WJZwZT2MVg7uL6Z3udVdOuEXh5bB4h80Dp1RGsC/2eXCXTnuEFyZxd9UPOBtRJCXfMg F8jbn7+Xmz6o9kn/j6fKAsKeRn33Z2BMwWV/3mrKJNs67KcJfzW/5/3hY151RtgKdQpDuR 5vFN6/5lJkdyEecaY8IaCAUaOBFQJw8= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-Ar-6_6msP2yrvvryKZZM9A-1; Wed, 27 Mar 2024 14:45:49 -0400 X-MC-Unique: Ar-6_6msP2yrvvryKZZM9A-1 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-5cec8bc5c66so51331a12.1 for ; Wed, 27 Mar 2024 11:45:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711565148; x=1712169948; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SwrxKD/873ovZB9okVvIeRPiM2lgQozGPeLRLoYV9I8=; b=jnjZ1MScIg0NeU8FlPImZhrbux5R/Y76Ws8qfJPFuVlOgeV8D/3pvSn2K1AWksJGhm tFLDEFlYcnorf/BUs+9C05Kq7pB+uTjFSOhOu21IXnjwTWkxbqR0IZnAyjNgA8ioHLRk o/nWEd9JxKl2jc8JsVLNE8O8dkvUqDk+yEwjcegrN4uPNqqzocbsSlpUiKU35YPODnfI mba1Z09xbJVgFSOLDif0vUQpX3YHIkTJr54LublZVFSuxG1qfxvbWepsTu6Upt+58E2G ZMMVFrO3+zxzYOX115JYUZr9iyBrLSGMOgo7PsxZS+GNe3hH/Y0XBQdoOtDtEbPTdXfY aJrQ== X-Gm-Message-State: AOJu0Yy3Qg7fbAiN3mFNKSAudTIHAwSuQY4eomzhdfoO/160k+EaBCdr b5njoIUjIbTWuFbQCaH+XHFYgWn699gf6bkwza+Rrcasgsh7Z7cLzLwfaAm3yTAanK59d/x4jiB COev7N3dqVpB6Eyv+aNmR1iGhij/BPuvS5JsuMcKLwUMwAcxng1nL6c0O0a/SQhPskMmTWlu12D tI2sUexf239MDzg51ISnFSA4PNUe5e3C4AwhLyIqAQI2g= X-Received: by 2002:a17:90b:124f:b0:29d:32cf:aa6c with SMTP id gx15-20020a17090b124f00b0029d32cfaa6cmr474858pjb.39.1711565148073; Wed, 27 Mar 2024 11:45:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFV3H7DSxPcbDa9k6CW0Obv9XXqCyvKwqsm6R8KFC1hVAZ7Gv5T8UxmTJQKRN9zQ+tMeLOF3d7hlFz/a+KSym8= X-Received: by 2002:a17:90b:124f:b0:29d:32cf:aa6c with SMTP id gx15-20020a17090b124f00b0029d32cfaa6cmr474845pjb.39.1711565147772; Wed, 27 Mar 2024 11:45:47 -0700 (PDT) MIME-Version: 1.0 References: <20240327120044.3097591-1-josimmon@redhat.com> In-Reply-To: From: Joe Simmons-Talbott Date: Wed, 27 Mar 2024 14:45:31 -0400 Message-ID: Subject: Re: [PATCH v10] posix: Deprecate group_member for Linux To: Paul Eggert Cc: libc-alpha@sourceware.org, Florian Weimer X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 27, 2024 at 12:24=E2=80=AFPM Paul Eggert w= rote: > > On 3/27/24 06:00, Joe Simmons-Talbott wrote: > > + int gm =3D __group_member2 (stats.st_gid); > > + if (stats.st_gid =3D=3D ((flag & AT_EACCESS) > > + ? __getegid () > > + : __getgid ()) || (gm && gm !=3D -1)) > > + granted =3D (unsigned int) (stats.st_mode & (mode << 3)) >> 3; > > + else if (gm =3D=3D -1) > > + return -1; > > This is not best, as it calls __group_member2 even when (stats.st_gid =3D= =3D > (flag & AT_EACCESS ? __getegid () : __getgid ())) and there is no need > for the __group_member2 overhead in that case. The old code didn't have > this problem. > Indeed. I've posted a v11[1]. Thanks, Joe [1] https://sourceware.org/pipermail/libc-alpha/2024-March/155633.html --=20 Joe Simmons-Talbott