From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9927D3858D20 for ; Thu, 11 Apr 2024 16:57:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9927D3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9927D3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712854670; cv=none; b=vR9XlysFfkw7es5s/YEPnSj+kFvA14SqLHKhxThy8p88/i+kCCMKSGyyqDxaQEJBq6YhyYulVgO7NAq1beHIgq8Imdq8cC58dyuCppzZ2vOx3y9tlE3Pg+CEXjuRUxmgnHLcax98COEMY7aA9Yd+vThE62NEe27QxvOQh3VhSmo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712854670; c=relaxed/simple; bh=ZviOzVlmeOrp2zbYkPaDKsHioz1GAbqRJ2y8LnDOowY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=KL7aDcYh2J0BEi4PvZvX/gtaVzarRKUsDh0dt1bFCEFN9SDRG3ZCcS/vit6JgJc+SNw/Xwu49LlYM1o5cTeCtXoNYhJsyiEK9jDzSeUKTTO2bRnmMRKFhv7wptJ1ov98mGLKzpM4z+RRM88ZciMRMiSd/t0cqjMuF0icPb2CnJI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712854668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kMLVyPJz7JBL4W27KHXtH8h0Z654qaB85z5x+DbVdEU=; b=g30fg832uH3WIHEIltQc3O/oYk3TIoW+phu3zMf4hg+inldL4sYBDFBHpnoQe0M81uE2gD KwVSUTu0IfcM4CGfwPikM//VsTdbuwYIWY0VXTCnXfiGVGUG/3LfzokaZ+OfAnp7+9tcnF dUp4KFMZNK78PcdPrOHkyaflb9Si7fw= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-304-62oZv4RrMv6LeSMEp6yxlw-1; Thu, 11 Apr 2024 12:57:46 -0400 X-MC-Unique: 62oZv4RrMv6LeSMEp6yxlw-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a51d062b178so712066b.2 for ; Thu, 11 Apr 2024 09:57:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712854664; x=1713459464; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kMLVyPJz7JBL4W27KHXtH8h0Z654qaB85z5x+DbVdEU=; b=vPQUOthqV4VhuRHXCUIJl2gtOchw878bVvaZv4TZZbI+8OTkfXK5FLZa91bcF9cBcL smbecplIZW/e92aXqIuevjkk45nuRlJevICQXHu3NB2htHtWc+ojbNBkczQa/VesT8lq HCpJcxE9N9kZdfoPUP55/ondaiIorEeoRnVF2EjFqbA++6FS2szN9CTtHb++vwKOn2RX psh7xMPKB7EEEmswYTaNj9eSN3jxQHvN3/AEtQ4e9/4gG4ink6f2LSs65ZM5tdS/pHwC D5ILn49G2MlCljFbl1lSD8aoXtbCd6XrDUuSMVtbRQcRK1wBy0f5MyGATGPOdbzK9n8j cB0g== X-Gm-Message-State: AOJu0YzVW03drHKBH0cjsVbI4Aimx0ekqH98NDxQ1l0t6TZgUVQb6nMr cDX6W15kHaIZ3jb0/TrVE0ESzRfh17wTkT5s4h7o5pOwmTA5+ObWVtY7lAdfg4HEqceaD86fQfd +Wob3X/x4JClgwTaMaxCDZm8xcwCLHtioDmS3q4z77n+dFA6JpfJwvDdtSZkm4C3di+dC5Rs8U0 +SSsAcoAR+hQ2m1s/fS1fgHpSBbPTuapxe+hPNarQQjRc= X-Received: by 2002:a17:906:c111:b0:a52:1751:22ea with SMTP id do17-20020a170906c11100b00a52175122eamr215044ejc.45.1712854664421; Thu, 11 Apr 2024 09:57:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTxSWy+oymCtdnQT1+pNDReWtf3Y2tNj5uG68V1Cgu6WD5BS3P0LGhVfrvvvskvnK4UCYEezLRN3ha5EL9+00= X-Received: by 2002:a17:906:c111:b0:a52:1751:22ea with SMTP id do17-20020a170906c11100b00a52175122eamr215037ejc.45.1712854664122; Thu, 11 Apr 2024 09:57:44 -0700 (PDT) MIME-Version: 1.0 References: <20240307214032.2773074-1-josimmon@redhat.com> In-Reply-To: From: Joe Simmons-Talbott Date: Thu, 11 Apr 2024 12:57:28 -0400 Message-ID: Subject: Re: [PATCH v2] elf/rtld: Count skipped environment variables for enable_secure To: Andreas Schwab Cc: libc-alpha@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks for your review. I added a testcase to the v3[1] patch that triggers the assert without the patch and does not trigger the assert with the patch. I'm not certain it's a useful test though since it's essentially testing that the assertion isn't triggered. Thanks, Joe [1] https://sourceware.org/pipermail/libc-alpha/2024-April/156034.html On Thu, Apr 11, 2024 at 9:46=E2=80=AFAM Andreas Schwab wro= te: > > Can you please add a test? > > -- > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint =3D 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D= 7 > "And now for something completely different." > --=20 Joe Simmons-Talbott