From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 6161B385841C for ; Sat, 25 Dec 2021 07:24:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6161B385841C Received: by mail-ed1-x531.google.com with SMTP id m21so41929812edc.0 for ; Fri, 24 Dec 2021 23:24:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=islgDRvLmIkVaW3Txiz9Hblk6YW3+ysBM2HJxSMqLp0=; b=EvP7bTvAmyfcHz3LW93JeuA5+ru9wN8PQP994i9aaIiFKp2mvDlLH/K9xRG9zbJGEV sinSIrxLx/1CQ4ik2TXl/IrQCfFue3/F0fVWS2zU+qD9+y7nGVT/bU+eSiU/Y9fu9AJG qXTETv21s1DDPlJVhZSzpEgiJg9QEeQa3ha9/e1MpL+wfZxs2oLl0JTKkKtznSA5b7Bv QoYHSNUU4Rgv/pb+L4lg5OKhfbP9HEQJvwT3Jl16YKjXhp5FKjnPEuVqFqDvcQnn7yeW Cw7t5o2ABGsZ6iaV+5br/SSYft97CXP0G96zmXT4a9ntWtQkJX34b9U9o9wJqv00Vo7e 1A4g== X-Gm-Message-State: AOAM532pX47/mOPNtZmsdTktVC3qpYhcY4yca4fmMxnwseRGi9cOWoS1 6VbPUuc/K2Y3l2TCkB5MxMv0wlQaj+afzus4MBU= X-Google-Smtp-Source: ABdhPJxQYvoqVY9PY94n0lFaths8yKnEvZZz33MX2KOyEGVTX4ukF1Yc6RFKOe3ysozrlErIMBg6P7ztao965VsdLnc= X-Received: by 2002:a05:6402:354b:: with SMTP id f11mr8363964edd.342.1640417084506; Fri, 24 Dec 2021 23:24:44 -0800 (PST) MIME-Version: 1.0 References: <20211210233456.4146479-1-shorne@gmail.com> <87pmpnnwjf.fsf@igel.home> In-Reply-To: From: Stafford Horne Date: Sat, 25 Dec 2021 16:24:35 +0900 Message-ID: Subject: Re: [PATCH v3 00/13] Glibc OpenRISC port To: Andreas Schwab Cc: Stafford Horne via Libc-alpha , Adhemerval Zanella , Openrisc X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Dec 2021 07:24:46 -0000 On Fri, Dec 24, 2021, 6:26 AM Stafford Horne wrote: > On Thu, Dec 23, 2021 at 04:57:56PM +0100, Andreas Schwab wrote: > > On Dez 24 2021, Stafford Horne via Libc-alpha wrote: > > > > > It seems the write to the tmp file was failing due the re-open not > passing > > > O_LARGEFILE. > > > > open64 implies O_LARGEFILE, so if that is making a difference, then your > > open64 is broken. > > Right, that is what the docs say. This architecuture is 32-bits. > > And the open64 path is generic. > > Possibly this bit removing O_LARGEFILE is wrong? > > In sysdeps/unix/sysv/linux/open64.c: > > 27 #ifdef __OFF_T_MATCHES_OFF64_T > 28 # define EXTRA_OPEN_FLAGS 0 > 29 #else > 30 # define EXTRA_OPEN_FLAGS O_LARGEFILE > 31 #endif > > Otherwise there is something is wrong on linux. It is explicitly checking > for the precense of O_LARGEFILE. > > in fs/read_write.c in generic_write_check_limits: > > if (!(file->f_flags & O_LARGEFILE)) > max_size = MAX_NON_LFS; > There's something wrong with __OFF_T_MATCHES_OFF64_T in this port. We have 32-bit off_t in Linux. So __OFF_T_MATCHES_OFF64_T should be undefined I think. I'll look into. -Stafford >