From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 1C37A3858416 for ; Fri, 8 Oct 2021 23:19:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C37A3858416 Received: by mail-ed1-x52c.google.com with SMTP id i20so25608348edj.10 for ; Fri, 08 Oct 2021 16:19:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N1oStFr3fbiskH/CM0wfcg29wV5KIQO4Sqe5GiGsnUI=; b=IzCwqot8w9wQ6icCzudsr0nKEkuWI4dr1D8GDIjXfCKwhIT0UmMmmPf9aXv3prI34n +SWERPOUVSROZ4e31UkQhxyl6GTiNdn85MbULrMU4EGlUIyqdRaI1//J3lcWAFpdhYOm tmV2rBClfdA0fGEbVa2L2RkQS1/TwS3j9MhhSe9dUqA7G8+f0PibRpt6FIeByl2hq3cR /pmxvByVZGyca36ELdevtpIHsX9qnNy3+Ax63bNtbhusdKNoOZ15Rxexm7UMa/+rHt7w U1EV2PjOeVazrzVLg9J7gfVDpVKjhBzdhCNlTvFByBl3zf80TiYJ6zAW5Dkh4nKfYwqr Fpqw== X-Gm-Message-State: AOAM533Mvdpn6+Sj5cxKhUmeowz6GFuBtsYS9f0wV43ec48cEdarwifb 29x4ozizTVjq6/Vz6lfPGwPFTXoO/uIW94LiIKWpQhTQk9Y= X-Google-Smtp-Source: ABdhPJwPxKMXFSOF2YxMb9D4IGE7Jv1/UNz03DQjzIGq3l1DUINVZgCnRHvFuV8nOBIQGLxMtKF+PFsZRSeOc1858SI= X-Received: by 2002:aa7:c78f:: with SMTP id n15mr19530265eds.338.1633735141168; Fri, 08 Oct 2021 16:19:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stafford Horne Date: Sat, 9 Oct 2021 08:18:50 +0900 Message-ID: Subject: Re: [PATCH v10 00/11] malloc hooks removal To: DJ Delorie Cc: GLIBC patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Oct 2021 23:19:03 -0000 On Sat, Oct 9, 2021 at 7:22 AM DJ Delorie wrote: > > > Have you backported 2d2d9f2b48a9 ? The tests that use the built-in check > either won't work, or require an LD_PRELOAD to include the externalized > replacement; there were a couple patches that cleaned all that up. > Yes, I rebased september 26th. That patch was pushed in july and it's there. Is the issue in malloc/malloc-debug.c? There is a big if for GLIBC_2_0 -> GLIBC_2_34. It seems from GLIBC_2_35 nothing is available any longer. Is that correct, that is what is happening. Maybe mtrace.c should be getting linked in to malloc-debug, I don't see that happening. #if SHLIB_COMPAT (libc_malloc_debug, GLIBC_2_0, GLIBC_2_34) /* Support only the glibc allocators. */ extern void *__libc_malloc (size_t); extern void __libc_free (void *); extern void *__libc_realloc (void *, size_t); extern void *__libc_memalign (size_t, size_t); extern void *__libc_valloc (size_t); extern void *__libc_pvalloc (size_t); extern void *__libc_calloc (size_t, size_t); ... My git history showing the patches are there: $ git lo -n20 -- NEWS 2021-09-27 6e85a96b9a Stafford Horne or1k: Add documentation 2021-09-24 8807e560c0 Joseph Myers Define __STDC_IEC_60559_BFP__ and __STDC_IEC_60559_COMPLEX__ 2021-09-22 b3f27d8150 Joseph Myers Add narrowing fma functions 2021-09-19 a93d9e03a3 H.J. Lu Extend struct r_debug to support multiple namespaces [BZ #15971] 2021-09-10 abd383584b Joseph Myers Add narrowing square root functions 2021-09-06 466f2be6c0 Carlos O'Donell Add generic C.UTF-8 locale (Bug 17318) 2021-08-01 a85c93c424 Carlos O'Donell Open master branch for glibc 2.35 development (tag: glibc-2.34.9000) 2021-08-01 2e2c08aa4d Carlos O'Donell Update NEWS. 2021-08-01 cfdaa29f66 Mark Harris NEWS: Fix typos, grammar, and missing words 2021-07-22 1e5a5866cb Siddhesh Poyarekar Remove malloc hooks [BZ #23328] 2021-07-22 0552fd2c7d Siddhesh Poyarekar Move malloc_{g,s}et_state to libc_malloc_debug *2021-07-22 2d2d9f2b48 Siddhesh Poyarekar Move malloc hooks into a compat DSO 2021-07-22 55a4dd3930 Siddhesh Poyarekar Remove __morecore and __default_morecore