From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 3D4733855003 for ; Sun, 6 Jun 2021 16:27:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D4733855003 Received: by mail-lj1-x230.google.com with SMTP id m3so18533239lji.12 for ; Sun, 06 Jun 2021 09:27:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dpuMn3tPLZty3oaha4Z4GLhGw/OVp/lqdio+Z/mWzOg=; b=roGigp+lEmVECw4s3IeE604HOfThqYcvjQBbBd7tovnqLMn97l/gF7Y3QednmQPJsi GNLU7ERE3IwEhGDouMltVpgFXanH7smIz4/j2B+GW6YDDEyjdXURuldkY99H5yvqevR8 YkShsFGhl/Ud0wL5jxZY6XzPGo9CJa+BsWO+GbSkYHMn7jE9VhnOUYv7MGppojw0mQoK 3o7/rFKiVHrvNwpoe6LBD8EAUwQye6kuEVYJo/hpxFC3UAVl/uYNfv2BHnT8+jCMVi/A aKQoZw0q5Ilf46++xjUWl586LqkBN1JPDxtWoeqZV01LHmH3j6RY1asF+h5RQgXCHWAR B3Xg== X-Gm-Message-State: AOAM530ghRM84Yi8fUXmQWy+18XO68YciYrT5H/BoyZdY/AqFcNMe4NB t8G/+1Qa7Q+2O36EiuyUVWjCUyYGWphlxvnzD3471Q== X-Google-Smtp-Source: ABdhPJx6Au85/x1MYB3xs8/8fFtSswWK8Vw3c2TNWzZOylIa2gCfWhYrUdgpN5DbVT+d4KC1UH2tQEKeIeu2EDsD3Jg= X-Received: by 2002:a2e:858a:: with SMTP id b10mr11434980lji.445.1622996835660; Sun, 06 Jun 2021 09:27:15 -0700 (PDT) MIME-Version: 1.0 References: <87mtsgmcy2.fsf@oldenburg.str.redhat.com> In-Reply-To: <87mtsgmcy2.fsf@oldenburg.str.redhat.com> From: Fergus Dall Date: Mon, 7 Jun 2021 02:27:03 +1000 Message-ID: Subject: Re: [PATCH v2 1/2] rtld: Add --no-default-paths option To: Florian Weimer Cc: Fergus Dall via Libc-alpha , Mike Frysinger , clumptini , chromeos-toolchain@google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-24.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2021 16:27:18 -0000 None of the other options in that file use "bool" even when they seem to only be used as booleans. I assumed this was out of a desire to keep C89 compatibility, though now that I look I see lots of other places in the codebase that don't do that. On Fri, May 28, 2021 at 1:08 AM Florian Weimer wrote: > > * Fergus Dall via Libc-alpha: > > > diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h > > index e383aa1dc3..f9f2c4126a 100644 > > --- a/sysdeps/generic/ldsodefs.h > > +++ b/sysdeps/generic/ldsodefs.h > > @@ -551,6 +551,9 @@ struct rtld_global_ro > > /* Do we read from ld.so.cache? */ > > EXTERN int _dl_inhibit_cache; > > > > + /* Do we search the default system paths? */ > > + EXTERN int _dl_search_default_paths; > > Maybe use a bool for this? > > Thanks, > Florian >