From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-71634-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 43895 invoked by alias); 8 Jul 2016 20:46:50 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 43884 invoked by uid 89); 8 Jul 2016 20:46:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=1756, Hx-languages-length:805, 54C7, 44D5
X-HELO: mail-vk0-f54.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=HkxBzrnVDpKvb7ldC+std1/MPMidE8FqqPq7cBFZzEY=;
        b=kpknv7RvMCI4zLxv/4rd5EQ07x01C2YCu/N8Eb0a2uDrVu3dsDfX1UiHAyCo1s7wiZ
         0GhP01lxl/pK+UmzMwaUrHBsMA/wOU3TmVifRF92vcsrnPH0xzW0oq6pMQJJWEP263cg
         hdRSKj7wZz/3PN8NBu0XdOU7BIOz8r+41i+Zd/UDV3kod4c2ir71mW9UMWFic4ybd8tP
         kYNt+mda+jhxDxoAvFrhitCBF7/UHeC3zPBKE8DQsjY+BVTcU1blUddNkeTzjUeljBJt
         jOj3MWBVIRIVsvbQ/R2aGi+JZb1Pn0Nv9QoM6R1y5LNbRbZFv2x6l4LGaWsuGGH5zB0X
         Q2JA==
X-Gm-Message-State: ALyK8tLntBlHyHAye+9vIZkD3xoHlgXIZ0DODJIShOT6XWKAsWq/TNDvMgPvcFOjXXS33gAqZ7VzDUdXVjjnvDhW
X-Received: by 10.31.232.67 with SMTP id f64mr3123983vkh.44.1468010797254;
 Fri, 08 Jul 2016 13:46:37 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <87inwlqjn6.fsf@linux-m68k.org>
References: <CABV8kRzPpdhRsWOsU+zNEc7AcAqTqm1xdWxM0rufGAjk=yn4TA@mail.gmail.com>
 <87r3b9qn3n.fsf@linux-m68k.org> <CABV8kRwo-Qo5Dnh73_46d6J6kPbZbvubeopXPj-RMOL8CF8Xyw@mail.gmail.com>
 <87inwlqjn6.fsf@linux-m68k.org>
From: Keno Fischer <keno@juliacomputing.com>
Date: Fri, 08 Jul 2016 20:46:00 -0000
Message-ID: <CABV8kRy7G3nGF7YBePHb9QzKQWM-oo9Bw1hQFjR8EfNwbtv33w@mail.gmail.com>
Subject: Re: [PATCH] Add CFI to x86_64 RTLD_START
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: libc-alpha@sourceware.org
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2016-07/txt/msg00231.txt.bz2

Might it make sense to change the macro to clearly
separate the string literals and the backslashes, i.e.

".globl _start\n"                 \
".globl _dl_start_user\n"   \
"_start:\n"                         \

etc.?

On Mon, Jul 4, 2016 at 3:37 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Keno Fischer <keno@juliacomputing.com> writes:
>
>> I should have probably sent this patch with more diff context, but
>> since this is part of a preprocessor `#define`, the backslashes are
>> still required, no?
>
> Yes, sorry, I missed that.  But please put a space before the
> backslashes outside of the string literals.
>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."