From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by sourceware.org (Postfix) with ESMTPS id D6DE83857C52 for ; Fri, 17 Jul 2020 02:53:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D6DE83857C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vincent.chen@sifive.com Received: by mail-pj1-x1043.google.com with SMTP id a9so182027pjd.3 for ; Thu, 16 Jul 2020 19:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wFUtJ7r4KzySOSqkVQHAce5woRStoHay9cS80UJ9vWc=; b=beabXl0HIGAIT7UMxOmxTA3bGX3PkwWbGAD5YTpp0kRXU+U1b9iYoOgpu3MLnypRmV 8p9MfwEwxJnWhEbGU2+ulVEz7k2sZ4nzosxo1dF9KijAqrwwGGysEXUbAjy7zHtxjF/I 9GwM0v1UR4Bjwwyv/vtP3YY4KcKRH7HqIV+rGomrk7GfDUHqsQxcAHJnUc+8YLW4IinH hxErFI4haZg/PGTXRm9WKcS5RpNGAXSGr/CT5Oitig+u0ZRScy/7PqWfK3LFxtJKv6// YBPnrc/XYff6k169hVFLE3s9aNXd3hVq5bBXhqi3QeIDtWA0sT9m6ox7dzJPFVKCPGly hdwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wFUtJ7r4KzySOSqkVQHAce5woRStoHay9cS80UJ9vWc=; b=YH1kecl7KiaDMw/dcahQ+KnYjGsi5zow20SuxaIPH0p8iLRzb64Lg4hUAB2G5Wzef3 hmOF2RgYrCdWo7A89BRTKaP8JQkEth7sEg23bNyrQE39ejlo5dorTXqyIued2w6JFp6Y sptkjHg10cw4fjXflLHLTTXlOLemVSLN0gTkvEc0xkG2DAOJCrNyH9LkpaH0/S1lAeff xB9R5LPEpMgJNqz8IekCSq+TnXL+LuP5U0ZEQWaKg/kTymBsjMvluMCTIEBFhf80e7T1 d3D/ngjFxG8UQe8z32xWDkHBlzKwT5N6t/uI63RUPVhLg3plbhOujj4c6MMkAoZJhZQn eW9w== X-Gm-Message-State: AOAM533DHapgLgjA5oTsumEoO9LhxZufKo1TMkIiivILiWpUes6NLGtQ VY42p3emmQFDfAf46Q/qjVB3FdZKdna8P7mXGB+b0qDd X-Google-Smtp-Source: ABdhPJzWbZMiGkHaCKYysjYWepC/NCiI4nKELBQ4Wvam1luZPhJVsDEGoayELCUkZPFMCxAuuTMrUPHTiPw55ptP4gQ= X-Received: by 2002:a17:90a:12c7:: with SMTP id b7mr8004158pjg.137.1594954426936; Thu, 16 Jul 2020 19:53:46 -0700 (PDT) MIME-Version: 1.0 References: <1594283178-9047-1-git-send-email-vincent.chen@sifive.com> In-Reply-To: From: Vincent Chen Date: Fri, 17 Jul 2020 10:53:36 +0800 Message-ID: Subject: Re: [RFC PATCH] riscv: Add support for STT_GNU_IFUNC symbols To: Joseph Myers Cc: GNU C Library , Palmer Dabbelt , darius@bluespec.com, dj@redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2020 02:53:49 -0000 On Fri, Jul 10, 2020 at 12:40 AM Joseph Myers wrote: > > On Thu, 9 Jul 2020, Vincent Chen wrote: > > > This patch adds the support for STT_GNU_IFUNC symbols to riscv ports. The > > Binutils' IFUNC patches are under reviewing and can be found in > > https://sourceware.org/pipermail/binutils/2020-July/112186.html. > > > > Any suggestions and feedback are welcome. > > We have the libc-abis mechanism that's supposed to ensure binaries using > newer ELF features don't run on older glibc versions not implementing > those features. So in theory an architecture newly getting IFUNC support > should get a libc-abis entry (at the end of the file, not with the other > IFUNC entries there). But given the various missing or broken pieces of > this mechanism (EI_ABIVERSION not set in the static linker for most > architectures, possibly not checked by glibc in some cases), that probably > doesn't matter much. > > https://sourceware.org/legacy-ml/libc-ports/2010-03/msg00044.html > https://sourceware.org/legacy-ml/libc-alpha/2010-04/msg00016.html > https://sourceware.org/legacy-ml/libc-alpha/2014-01/msg00375.html > Thanks for your reminder. I will add an entry for riscv toolchain at the end of libc-abis