Re: [RFC PATCH] riscv: Add support for STT_GNU_IFUNC symbols

[Vincent Chen <vincent.chen@sifive.com>]

On Thu, Jul 9, 2020 at 4:42 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Jul 09 2020, Vincent Chen wrote:
>
> > diff --git a/sysdeps/riscv/dl-irel.h b/sysdeps/riscv/dl-irel.h
> > new file mode 100644
> > index 0000000..9dd8de9
> > --- /dev/null
> > +++ b/sysdeps/riscv/dl-irel.h
> > @@ -0,0 +1,53 @@
> > +/* Machine-dependent ELF indirect relocation inline functions.
> > +   RISC-V version.
> > +   Copyright (C) 2012-2020 Free Software Foundation, Inc.
>
> I think that should list only 2020 as copyright year.
>
> > diff --git a/sysdeps/riscv/dl-machine.h b/sysdeps/riscv/dl-machine.h
> > index 03db94a..728e6d3 100644
> > --- a/sysdeps/riscv/dl-machine.h
> > +++ b/sysdeps/riscv/dl-machine.h
>
> > @@ -248,7 +256,12 @@ elf_machine_rela (struct link_map *map, const ElfW(Rela) *reloc,
> >        break;
> >      }
> >  #endif
> > -
> > +    case R_RISCV_IRELATIVE:
> > +      value = map->l_addr + reloc->r_addend;
> > +      if (__glibc_likely (!skip_ifunc))
> > +        value = elf_ifunc_invoke (value);
> > +      *addr_field = value;
> > +      break;
> >      case R_RISCV_JUMP_SLOT:
> >      case __WORDSIZE == 64 ? R_RISCV_64 : R_RISCV_32:
> >        *addr_field = value;
>
> Please keep the empty line between each case bock.
>
> Andreas.

Thank you for pointing out my mistakes. I will modify them in my next
version patch

>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."