From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by sourceware.org (Postfix) with ESMTPS id 639B03857C52 for ; Fri, 17 Jul 2020 03:05:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 639B03857C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vincent.chen@sifive.com Received: by mail-pg1-x541.google.com with SMTP id p3so5986244pgh.3 for ; Thu, 16 Jul 2020 20:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GzCFntJipTo62M/hsyCA+eqECbeM0qMZjjw6aeYfsmk=; b=FdD+FP7yx/pVVdQ/OkgqW/isw+hKF85fG3Bd9fOs3wQPXxAU5hq67m9gDMMzx9GQan PHjPrpipeWzh+oTNiuh0+OyjC/1/txaxR1gOnYJiajhkw484uI+WAeDEcgmepf+quiWS ZByk/McEi8Glgjn3D563gdGLj0bXiDFfCXQjJG083gF7lioR929lSbcxlXb79bKDHL+7 q6AatNk9ntIddBZ+qViihaM0siG2cwpjrCLMR70pz6qEVryzuXoo8DptF3z9FzVpnHRy WE7c3GZxnj0J7kis/fuvgiQKLEdohmmMN5bHZ4rVZoMJ+Jdh65VpQGBbzGEHYaRc1WRC C0Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GzCFntJipTo62M/hsyCA+eqECbeM0qMZjjw6aeYfsmk=; b=ByqYr68lOwFSQzSoECKap+xDvdxBv9cOhyKVFVcw6JC6LpdDAQTICXXddccXVOsRQZ r7qES3JLdgp6768BL7h9RglPtvNtNE18AxlR9oRYGIRMs+aAqD1K5z7hhxBvqSipm5jA MWwfuDt2Z7YTTYJ/2NGI51JgkKLMw8Mns499TOU5qn0HN09ndCpFIZvYL0E851OhKH2N J6CXNrPMIRbQF9rN7ZysEG3jNN/4ZJrn/8jx3oh18n8FLo8AR4/qfObEzEISVAJ9K6Rs 43TBrtM9FCoh33BJiCp2tXWIODLhIUGPcqkFV2Hjiu7wmMV7sW6Ymv1GAbPjmASQAbVT Vn3A== X-Gm-Message-State: AOAM531nNSGi7uOP5po9fdJdYn8jpOA4i9u1aLlvrTQXTmDc/Iozpemc G3joW6xW5YEkQw8I5+Ps9u8SZEDAxcV1MtHjjhzrpSjSRH4= X-Google-Smtp-Source: ABdhPJzIYz/AS7VbMp7lxgSkDByflMtIvCOWzr35x09c3JnJZwGcO4LPt1S5iHIJRmf3+frup6vJBxDc52BE7o7cBvs= X-Received: by 2002:a63:fe0a:: with SMTP id p10mr6737894pgh.255.1594955149539; Thu, 16 Jul 2020 20:05:49 -0700 (PDT) MIME-Version: 1.0 References: <1594283178-9047-1-git-send-email-vincent.chen@sifive.com> In-Reply-To: From: Vincent Chen Date: Fri, 17 Jul 2020 11:05:38 +0800 Message-ID: Subject: Re: [RFC PATCH] riscv: Add support for STT_GNU_IFUNC symbols To: Jim Wilson Cc: GNU C Library , Palmer Dabbelt , Darius Rad , DJ Delorie Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2020 03:05:51 -0000 On Sat, Jul 11, 2020 at 7:16 AM Jim Wilson wrote: > > On Thu, Jul 9, 2020 at 1:26 AM Vincent Chen wrote: > > This patch adds the support for STT_GNU_IFUNC symbols to riscv ports. The > > Binutils' IFUNC patches are under reviewing and can be found in > > https://sourceware.org/pipermail/binutils/2020-July/112186.html. > > There is an existing bug report with a patch, though that patch was > never tested with working binutils support. See > https://sourceware.org/bugzilla/show_bug.cgi?id=24868 > Hopefully this patch fixes that bug. > > Jim I followed the descriptions in the Bugzilla to create the case and executed it in the environment with IFUNC support. No matter which binding scenario is used, (RTLD_NOW or RTLD_LAZY), the execution results are as expected. Hence I think this patch can fix this issue. Thank you.