From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id F06D63858C78; Thu, 18 Apr 2024 18:29:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F06D63858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F06D63858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713464961; cv=none; b=kIxYAzs5FgvTSys/uxQozHz4v0cyX2ihxsl8bBSQECxzS9To++J0LOroxp9KUcUSdxViiVdb+w3zNfv2sKMjK4BnKimmaDaLrKMykJK3TB4W5Ii9g8FDrkfLC1PlU5bJj8vb4eloTDXDM+QXsDR7Cy4IKuOrwFzW5rUei8WqFFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713464961; c=relaxed/simple; bh=IhMfPsNdo3Konq2CmXOwe/URJrsKLL5bl1PXZ53fXEg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=i2yyuLWCmWFeGRg0P3Rc6Vpp+zwwr5eHEJDQcFX7oVJkwo19jwDc/hRk3yPBIAFANG1YPRnzx8kqPY1ePcMGj7FgjX0xGfgcV749/iGuXA2NUGJmZC1HkwxM3TZ+65bpA3nxLuHVWzD49M9SwVxEzDanCDrJCBiU84TxHsyWunI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6ed32341906so1239036b3a.1; Thu, 18 Apr 2024 11:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713464959; x=1714069759; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=phuiDFO+ureHKjrd9BQ/l3bIaZQsYC/5JHgKYW3xG74=; b=M5uJ9eXzDohqpsFTsciLjLYnftflETslWJ4gOZzRCN6pj5Wn3In9DRU8a9aZXp0YO1 cRVdT1eqaXIX/+89CJKrF3pxDOuVws4G3rGr+nZvpNMZicvuCSkVmsvdyLTGoyRjL5rl HY3jG6VvvO5g1+UvgrnomWnU2fN3YUsRthM+KCZBNT4h4lUjgof5aBNA8leNvAMLg+/G 3rhLr3SyldTjaN6ljPl8M1YYxbrMO2goN784M/DJNNkC6WrMlrTYMS9m3m+ZbE+hQt8C wvS7hE0YOOYWzAeZuwqLMS0iSHuh73kwNmgD7aK5avpA4WTqSrG1oRhPZLteuTVckpmY NclA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713464959; x=1714069759; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=phuiDFO+ureHKjrd9BQ/l3bIaZQsYC/5JHgKYW3xG74=; b=Armw0+g0ZZOpVYhD1kt3x3hhUvSdTPczDpfhWzWXHsyEd1jGpaST6wuqJle0tRW2b5 spqWu/k/auDpKDgBhW+9BRZfpY/Ac2XFOC3iKYjdROgTjOuYvOgfmdA2X+APIWolS2WK G2IEqA4m23a8MoIDzaVEkt8NHFm/cEsieHaqteQNNyLEgr0FraaJrR9AiIEWEkzJkJWC OyXFGUj/XCpojTOB5VGyuMn9K4W/uf69iEqUnyqJnZglC/2r7iUoZtYvjudq9SejxKRe uhRNdBDfyKuEDInWzog/AnRz2wyKyYO9mF4HbdLxusRP+riwYphcl57QDOzxEx/hu/6j aKMg== X-Forwarded-Encrypted: i=1; AJvYcCV9x72tdMESETsgMR6rGsFcuHe423ZhGlFLnk01HNUY8CkcbYrMtQATgkE474zxuAutDfj6GTpSYPaaWUAnPcTbZMD46i0iTtO/+msM1hRY6d3TOY7Pr+gf/chECXvNnG2tJ5gLfMmzAY/YxpyE0D4tUfIl6WSe X-Gm-Message-State: AOJu0YxoEdBtzM7+v56lVWf1AFbMw+MWvun9c954J1834ZcL+PeJiJnL wIjNt3x1KFjimpXZy9SxRBIJfVmNh2N4qjfv33kWZ7MnZ3+LCOcL6V9kybeaSDC9rNQhXYa2lgU fslMwwU270gL/FXRfedzGexgkCip5GdjdKKZuzA== X-Google-Smtp-Source: AGHT+IGJRiqqxdhZ5X5o/Kzue3xSwIhjsID7ecpo4IqezGu4IhZo84fPYsOYjmuULZvPAY/UO7cBwsoHRWEin0+Yric= X-Received: by 2002:a05:6a20:5651:b0:1a9:90e0:4760 with SMTP id is17-20020a056a20565100b001a990e04760mr12695pzc.56.1713464958898; Thu, 18 Apr 2024 11:29:18 -0700 (PDT) MIME-Version: 1.0 References: <20240417232725.GC25080@gnu.wildebeest.org> <20240418173726.GD9069@redhat.com> In-Reply-To: <20240418173726.GD9069@redhat.com> From: Matt Rice Date: Thu, 18 Apr 2024 18:29:07 +0000 Message-ID: Subject: Re: Updated Sourceware infrastructure plans To: "Frank Ch. Eigler" Cc: Overseers mailing list , Mark Wielaard , Joseph Myers , gcc@gcc.gnu.org, binutils@sourceware.org, gdb@sourceware.org, libc-alpha@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,URIBL_SBL_A autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 18, 2024 at 5:38=E2=80=AFPM Frank Ch. Eigler = wrote: > > Hi - > > > [...] I suggest that a basic principle for such a system is that it > > should be *easy* to obtain and maintain a local copy of the history > > of all pull requests. That includes all versions of a pull request, > > if it gets rebased, and all versions of comments, if the system > > allows editing comments. A system that uses git as the source of > > truth for all the pull request data and has refs [...] > > Do you know of a system with these characteristics? > > - FChE The closest thing I know of which may have these characteristics is alibaba's AGit-Flow described here: https://git-repo.info/en/2020/03/agit-flow-and-git-repo/ It actually sends pull-requests through the git protocol using a custom proc-receive hook. I'm a bit uncertain how code-review comments are handled in their system, And it isn't exactly something which can just be used off-the-shelf, AFAIK their server side implementation hasn't been released. I had written a prototype-worthy implementation of the server-side git hook here. It basically allows sending a pull-request through git push, along with a cover letter. But i've never really used it in the full PR review cycle beyond that. https://github.com/pullreqr/pullreqr_githook But protocol-wise IMO it seems like a good basis for building a system with these characteristics to me.