From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 3ED353857C4F for ; Thu, 30 Sep 2021 09:22:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3ED353857C4F Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-T0NRA29HPYefpt55Zsx_PQ-1; Thu, 30 Sep 2021 05:22:31 -0400 X-MC-Unique: T0NRA29HPYefpt55Zsx_PQ-1 Received: by mail-vs1-f72.google.com with SMTP id v12-20020a672f0c000000b002d7c2f1d9ffso1072324vsv.14 for ; Thu, 30 Sep 2021 02:22:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cl9EWNPWJ96Jq8+3oToXvZJ9CNndNpNUKHvtFOLmKEs=; b=f4wlV0l37b/SS34KiQAozk0Nkz4suFpkZO5z+yvZeWcrMJfXV9X6MB9IztEMn/2wFv HXRzUbfnInOiZtYYzPmJr6i9k8vQpW/Hhofz2oWa3b/FpLkzssJKRFHupEvg5UJq4aAD akBH1UrXIXmsbMBZwgp7xFlGRIbuRtbtWSgfvF7utkjusX2zTzDWAM6oNrduB0TYNAz0 yWJpL2LaqTQZtj0+TL2c5FLHNIwAQLtiWjzVCXePKK4wAsx1F3GvRASJLDk9KAoGtsz3 mKLr1zQTNu772Fbl1FHFwrpPcJqIoEl1GA+KsnyuF0vTEBJWbbJxL5JkGgMvxtZ15Jtc GQ0Q== X-Gm-Message-State: AOAM53038EI96AX9W5zKexxCoqXObQ0BwKuAXgcQ4TLMPvZVOLznVzvo CeKcUvPHozRXgvN7h8HnQxka4FwmajOhy0DhLI5VVYESy9eMyo+h7CI3E2eL+9GJALYLy6WfPJT +jQiNqQBdXXVJXiDf/F0xm72aLOfAcXgAOV5J X-Received: by 2002:ab0:6848:: with SMTP id a8mr4288919uas.70.1632993751292; Thu, 30 Sep 2021 02:22:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLprsqlVPPqm3mI7ytjhSqYudwKGvp4miqNbfYTpVIyqLFcIgioyFy8t6JV0tEzhljXKI0TfpInr4MgN+CjqY= X-Received: by 2002:ab0:6848:: with SMTP id a8mr4288910uas.70.1632993751074; Thu, 30 Sep 2021 02:22:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Thu, 30 Sep 2021 10:22:20 +0100 Message-ID: Subject: [PATCH v2] Suppress -Wcast-qual warnings in bsearch To: Joseph Myers Cc: GNU C Library X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000074ac3405cd32fcee" X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2021 09:22:37 -0000 --00000000000074ac3405cd32fcee Content-Type: text/plain; charset="UTF-8" Ping for patch originally sent in https://sourceware.org/pipermail/libc-alpha/2021-May/126572.html The patch still applies cleanly to current master. On Wed, 19 May 2021 at 16:50, Jonathan Wakely wrote: > > On 19/05/21 15:37 +0000, Joseph Myers wrote: > >On Wed, 19 May 2021, Jonathan Wakely via Libc-alpha wrote: > > > >> +#pragma GCC diagnostic push > >> +#pragma GCC diagnostic ignored "-Wcast-qual" > >> return (void *) __p; > >> +#pragma GCC diagnostic pop > > > >I think such pragma uses in installed headers should be conditional on > >__GNUC_PREREQ (4, 6) (either directly or via conditionally defining a > >macro in sys/cdefs.h). > > Good point. > > I spent about two minutes trying to do something with _Pragma in > sys/cdefs.h to allow: > > __GLIBC_IGNORE_WARNING("-Wcast-qual") > return (void *) __p; > __GLIBC_UNIGNORE_WARNING > > but didn't get it working, so here's a patch that just tests > __GNUC_PREREQ directly. > > --00000000000074ac3405cd32fcee Content-Type: application/x-patch; name="bsearch.patch" Content-Disposition: attachment; filename="bsearch.patch" Content-Transfer-Encoding: base64 Content-ID: <17c36012bfe15f111e42> X-Attachment-Id: 17c36012bfe15f111e42 Y29tbWl0IGVlN2MyNDUxYTEwMmI0Y2QzYzg3YTMxYjMxNTZhZDQ0NTg3Mjk4NDANCkF1dGhvcjog Sm9uYXRoYW4gV2FrZWx5IDxqd2FrZWx5QHJlZGhhdC5jb20+DQpEYXRlOiAgIFdlZCBNYXkgMTkg MTY6NDg6MTkgMjAyMSArMDEwMA0KDQogICAgU3VwcHJlc3MgLVdjYXN0LXF1YWwgd2FybmluZ3Mg aW4gYnNlYXJjaA0KICAgIA0KICAgIFRoZSBmaXJzdCBjYXN0IHRvICh2b2lkICopIGlzIHJlZHVu ZGFudCBidXQgc2hvdWxkIGJlIChjb25zdCB2b2lkICopDQogICAgYW55d2F5LCBiZWNhdXNlIHRo YXQncyB0aGUgdHlwZSBvZiB0aGUgbHZhbHVlIGJlaW5nIGFzc2lnbmVkIHRvLg0KICAgIA0KICAg IFRoZSBzZWNvbmQgY2FzdCBpcyBuZWNlc3NhcnkgYW5kIGludGVudGlvbmFsbHkgbm90IGNvbnN0 LWNvcnJlY3QsIHNvDQogICAgdGVsbCB0aGUgY29tcGlsZXIgbm90IHRvIHdhcm4gYWJvdXQgaXQu DQoNCmRpZmYgLS1naXQgYS9iaXRzL3N0ZGxpYi1ic2VhcmNoLmggYi9iaXRzL3N0ZGxpYi1ic2Vh cmNoLmgNCmluZGV4IDQxMzJkYzZhZjAuLmQ2ODhlZDJlMTUgMTAwNjQ0DQotLS0gYS9iaXRzL3N0 ZGxpYi1ic2VhcmNoLmgNCisrKyBiL2JpdHMvc3RkbGliLWJzZWFyY2guaA0KQEAgLTI5LDE0ICsy OSwyMSBAQCBic2VhcmNoIChjb25zdCB2b2lkICpfX2tleSwgY29uc3Qgdm9pZCAqX19iYXNlLCBz aXplX3QgX19ubWVtYiwgc2l6ZV90IF9fc2l6ZSwNCiAgIHdoaWxlIChfX2wgPCBfX3UpDQogICAg IHsNCiAgICAgICBfX2lkeCA9IChfX2wgKyBfX3UpIC8gMjsNCi0gICAgICBfX3AgPSAodm9pZCAq KSAoKChjb25zdCBjaGFyICopIF9fYmFzZSkgKyAoX19pZHggKiBfX3NpemUpKTsNCisgICAgICBf X3AgPSAoY29uc3Qgdm9pZCAqKSAoKChjb25zdCBjaGFyICopIF9fYmFzZSkgKyAoX19pZHggKiBf X3NpemUpKTsNCiAgICAgICBfX2NvbXBhcmlzb24gPSAoKl9fY29tcGFyKSAoX19rZXksIF9fcCk7 DQogICAgICAgaWYgKF9fY29tcGFyaXNvbiA8IDApDQogCV9fdSA9IF9faWR4Ow0KICAgICAgIGVs c2UgaWYgKF9fY29tcGFyaXNvbiA+IDApDQogCV9fbCA9IF9faWR4ICsgMTsNCiAgICAgICBlbHNl DQorI2lmIF9fR05VQ19QUkVSRVEoNCwgNikNCisjIHByYWdtYSBHQ0MgZGlhZ25vc3RpYyBwdXNo DQorIyBwcmFnbWEgR0NDIGRpYWdub3N0aWMgaWdub3JlZCAiLVdjYXN0LXF1YWwiDQorI2VuZGlm DQogCXJldHVybiAodm9pZCAqKSBfX3A7DQorI2lmIF9fR05VQ19QUkVSRVEoNCwgNikNCisjIHBy YWdtYSBHQ0MgZGlhZ25vc3RpYyBwb3ANCisjZW5kaWYNCiAgICAgfQ0KIA0KICAgcmV0dXJuIE5V TEw7DQo= --00000000000074ac3405cd32fcee--