From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id E8B3B3858025 for ; Thu, 30 Sep 2021 16:52:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E8B3B3858025 Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-0FFjQufCMNWtwVtqQFno7A-1; Thu, 30 Sep 2021 12:52:54 -0400 X-MC-Unique: 0FFjQufCMNWtwVtqQFno7A-1 Received: by mail-ua1-f71.google.com with SMTP id 63-20020a9f2445000000b002c4023afb53so3333193uaq.17 for ; Thu, 30 Sep 2021 09:52:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E//Bi21zvHcZvZnqjt6Ynvt3OWzgT7ckQ8a3f/tM6lc=; b=xvkXWMTaVf/jJxZD5YfAP2IFNbRFlaKIBlCoGpPQ58701CO1rRSs8cRReM4ieIZr57 Mm+W/f2oQUVY2xzOpVfwNihaZtIdBGt8yItNx0GooCU5EX91fFGVCHswI1c/4t9nOmW8 Ssh+SvmP4Jn1S0f7bfnxdp/LKCCdpHFwHnD8+QLZOyjzoi7xZXvR2qxDmKDFHJJMCkWp C9ZF4hGqyYtIZjGlTQSqVuFVQqhfNok6W88eJmgv4oD4au6EOLPi9SFav6benFbhhqE4 WWcseeNAoVAovNxV+zvE3MezuUgwj21P84LRSj1PX9E5KM+7npd4xc0pjSAh/4vXMPV7 AUpg== X-Gm-Message-State: AOAM533hGXpFpRGDYVUOAJmV04eEAQMVWWsmQRiaAc3bvmStLe8cA+Bk vd1tHWkptJBir3nKFF/TNDDC9jN8SfkuKdbz+w3bM2noE0Xe+5MRFeTWJ+QO3GH4MUpuwd+GJCr AONkXwbaVVX+Axe8z+hMUtI9GFO7v5IFv01bW X-Received: by 2002:a05:6102:2421:: with SMTP id l1mr368268vsi.16.1633020774064; Thu, 30 Sep 2021 09:52:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlaDX3oaaacjUA5Vkwx6+NoC9GUsTG2jiYZGjZY/gSAYCCn1ibxTMV11gtfIO3N0uGsmXKRXsE55siscTcC3M= X-Received: by 2002:a05:6102:2421:: with SMTP id l1mr368235vsi.16.1633020773779; Thu, 30 Sep 2021 09:52:53 -0700 (PDT) MIME-Version: 1.0 References: <87czoq4a44.fsf@oldenburg.str.redhat.com> <069fcec4-d81f-3ea8-d87c-ff3b281dbe71@linaro.org> In-Reply-To: <069fcec4-d81f-3ea8-d87c-ff3b281dbe71@linaro.org> From: Jonathan Wakely Date: Thu, 30 Sep 2021 17:52:42 +0100 Message-ID: Subject: Re: [PATCH v2] Suppress -Wcast-qual warnings in bsearch To: Adhemerval Zanella Cc: GNU C Library , Joseph Myers X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="00000000000022089b05cd394725" X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2021 16:52:58 -0000 --00000000000022089b05cd394725 Content-Type: text/plain; charset="UTF-8" On Thu, 30 Sept 2021 at 15:49, Adhemerval Zanella wrote: > > > > On 30/09/2021 07:43, Florian Weimer via Libc-alpha wrote: > > * Jonathan Wakely via Libc-alpha: > > > >> diff --git a/bits/stdlib-bsearch.h b/bits/stdlib-bsearch.h > >> index 4132dc6af0..d688ed2e15 100644 > >> --- a/bits/stdlib-bsearch.h > >> +++ b/bits/stdlib-bsearch.h > >> @@ -29,14 +29,21 @@ bsearch (const void *__key, const void *__base, size_t __nmemb, size_t __size, > >> while (__l < __u) > >> { > >> __idx = (__l + __u) / 2; > >> - __p = (void *) (((const char *) __base) + (__idx * __size)); > >> + __p = (const void *) (((const char *) __base) + (__idx * __size)); > >> __comparison = (*__compar) (__key, __p); > >> if (__comparison < 0) > >> __u = __idx; > >> else if (__comparison > 0) > >> __l = __idx + 1; > >> else > >> +#if __GNUC_PREREQ(4, 6) > >> +# pragma GCC diagnostic push > >> +# pragma GCC diagnostic ignored "-Wcast-qual" > >> +#endif > >> return (void *) __p; > >> +#if __GNUC_PREREQ(4, 6) > >> +# pragma GCC diagnostic pop > >> +#endif > >> } > >> > >> return NULL; > > > > Patch looks okay, thanks. > > > > Reviewed-by: Florian Weimer > > > > Florian > > > > I am seeing a lot of failure on x86_64 with gcc 11.1 after this > patch landed: > > x86_64-linux-gnu$ grep ^FAIL tests.sum > FAIL: catgets/de/libc.cat > FAIL: catgets/test-gencat > FAIL: catgets/test1.cat > FAIL: catgets/tst-catgets > FAIL: debug/tst-chk1 > FAIL: debug/tst-chk2 > FAIL: debug/tst-chk3 > FAIL: debug/tst-chk4 > FAIL: debug/tst-chk5 > FAIL: debug/tst-chk6 > FAIL: debug/tst-lfschk1 > FAIL: debug/tst-lfschk2 > FAIL: debug/tst-lfschk3 > FAIL: debug/tst-lfschk4 > FAIL: debug/tst-lfschk5 > FAIL: debug/tst-lfschk6 > [...] > > For instance some math tests shows ulps failures that does not > make much sense: > > $ ./testrun.sh math/test-double-cacos > testing double (without inline functions) > Failure: Test: Imaginary part of: cacos_downward (-0x1p-52 - 0x1.0000000000001p+0 i) > Result: > is: 8.8137358701954271e-01 0x1.c34366179d424p-1 > should be: 8.8137358701954315e-01 0x1.c34366179d428p-1 > difference: 4.4408920985006261e-16 0x1.0000000000000p-51 > ulp : 4.0000 > max.ulp : 3.0000 > Failure: Test: Imaginary part of: cacos_downward (-0x1p-52 - 0x1.000002p+0 i) > Result: > is: 8.8137367131323707e-01 0x1.c34368ebb10d9p-1 > should be: 8.8137367131323751e-01 0x1.c34368ebb10ddp-1 > difference: 4.4408920985006261e-16 0x1.0000000000000p-51 > ulp : 4.0000 > max.ulp : 3.0000 > [...] > > Reverting fixes it. Huh, I wonder why I didn't see these. Sorry. I'll see if Joseph's suggestion helps (as attached) or I'll revert it. --00000000000022089b05cd394725 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ku75gupa0 Y29tbWl0IGYxNzYzY2QyZDNiNzc1ODIzMDkyODgxOThlNTZkZTVkODgzYjQyNWEKQXV0aG9yOiBK b25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNvbT4KRGF0ZTogICBUaHUgU2VwIDMwIDE3 OjI0OjU0IDIwMjEgKzAxMDAKCiAgICBzdGRsaWI6IEFkZCBicmFjZXMgYXJvdW5kIHJldHVybiBz dGF0ZW1lbnQgaW4gYnNlYXJjaAogICAgCiAgICBUaGUgZGlhZ25vc3RpYyBwcmFnbWFzIGFyZSBh cHBhcmVudGx5IGludGVycHJldGVkIGFzIHRoZSBzdGF0ZW1lbnQKICAgIGZvbGxvd2luZyB0aGUg ZWxzZSwgc28gYWRkIGJyYWNlcyBhcm91bmQgdGhlbSB0byBjcmVhdGUgYSBibG9jawogICAgc3Rh dGVtZW50IGNvbnRhaW5pbmcgdGhlIHByYWdtYXMgYW5kIHRoZSByZXR1cm4gc3RhdGVtZW50Lgog ICAgCiAgICBTaWduZWQtb2ZmLWJ5OiBKb25hdGhhbiBXYWtlbHkgPGp3YWtlbHlAcmVkaGF0LmNv bT4KCmRpZmYgLS1naXQgYS9iaXRzL3N0ZGxpYi1ic2VhcmNoLmggYi9iaXRzL3N0ZGxpYi1ic2Vh cmNoLmgKaW5kZXggZDY4OGVkMmUxNS4uYzRiNDg1ZWRmOCAxMDA2NDQKLS0tIGEvYml0cy9zdGRs aWItYnNlYXJjaC5oCisrKyBiL2JpdHMvc3RkbGliLWJzZWFyY2guaApAQCAtMzYsMTQgKzM2LDE2 IEBAIGJzZWFyY2ggKGNvbnN0IHZvaWQgKl9fa2V5LCBjb25zdCB2b2lkICpfX2Jhc2UsIHNpemVf dCBfX25tZW1iLCBzaXplX3QgX19zaXplLAogICAgICAgZWxzZSBpZiAoX19jb21wYXJpc29uID4g MCkKIAlfX2wgPSBfX2lkeCArIDE7CiAgICAgICBlbHNlCisgICAgICAgIHsKICNpZiBfX0dOVUNf UFJFUkVRKDQsIDYpCiAjIHByYWdtYSBHQ0MgZGlhZ25vc3RpYyBwdXNoCiAjIHByYWdtYSBHQ0Mg ZGlhZ25vc3RpYyBpZ25vcmVkICItV2Nhc3QtcXVhbCIKICNlbmRpZgotCXJldHVybiAodm9pZCAq KSBfX3A7CisgICAgICAgICAgcmV0dXJuICh2b2lkICopIF9fcDsKICNpZiBfX0dOVUNfUFJFUkVR KDQsIDYpCiAjIHByYWdtYSBHQ0MgZGlhZ25vc3RpYyBwb3AKICNlbmRpZgorICAgICAgICB9CiAg ICAgfQogCiAgIHJldHVybiBOVUxMOwo= --00000000000022089b05cd394725--