From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexandra.khirnova@gmail.com>
Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com
 [IPv6:2607:f8b0:4864:20::c33])
 by sourceware.org (Postfix) with ESMTPS id 69F6C385781A
 for <libc-alpha@sourceware.org>; Fri,  2 Apr 2021 12:13:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 69F6C385781A
Received: by mail-oo1-xc33.google.com with SMTP id
 s1-20020a4ac1010000b02901cfd9170ce2so1238383oop.12
 for <libc-alpha@sourceware.org>; Fri, 02 Apr 2021 05:13:27 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:reply-to
 :from:date:message-id:subject:to:cc;
 bh=V5+5mth27DvInxJnjl86z/eXaO4vx9Pe4KM76O0gqpM=;
 b=IcTsSJeoloXwXCpMMh04du8lR5iM3GvGPAprnhFROVzaYpgIDP7bksI6tw5UdRfK34
 Jbgt6Ow2o1OZshnpDb/wMtVlbC9wqZJ9glMzGzaIOTP8sceOgwrIeiqm/VPgssJ7Vrfa
 9YlBKIgKJU9mAPA37of2kOd7CxZLmVHBY7VNw+dDjPUE5iwFAc15uC8jjhebmodrHBPN
 PYcBdb7ocwVG4XJPYeZ27M02Sg0EgNuKRgLwga6PRX0TN0uhsg4ZysQz3nhurgYLR+gL
 3v8e1NIzXgRnGrJRQcKa39WYC7jo0v4S/NyYkpiXjRbQgGKBZ1B1IZSlOOuKtd8E/e4U
 Ki6A==
X-Gm-Message-State: AOAM531swKoit2+CBPgFPP6Lndb5Wdm6Xx1Wgf5oB2tl4038dmCGCk+Z
 mzXPGPeMMtt1KRFyxguDtIc0a2ED1stJkm3n5O0=
X-Google-Smtp-Source: ABdhPJwAxoDGpJSLu2WHCv/hu85DwmlW3mFTHWa9EIwbiYn5JWmYR6aBaiWnR6Jjvo9pqyb+33lQongnr6eG0FP7xg4=
X-Received: by 2002:a4a:2f4b:: with SMTP id p72mr11582841oop.27.1617365606815; 
 Fri, 02 Apr 2021 05:13:26 -0700 (PDT)
MIME-Version: 1.0
References: <20200428122019.26826-1-ahajkova@redhat.com>
 <20210324135402.2685623-1-ahajkova@redhat.com>
 <bfe7fab5-92fa-02a8-c074-58ccc64708c3@linaro.org>
In-Reply-To: <bfe7fab5-92fa-02a8-c074-58ccc64708c3@linaro.org>
Reply-To: alexandra.khirnova@gmail.com
From: =?UTF-8?Q?Alexandra_H=C3=A1jkov=C3=A1?= <alexandra.khirnova@gmail.com>
Date: Fri, 2 Apr 2021 14:13:15 +0200
Message-ID: <CACfmkTpaj=dXk1R7dwOjPHWtktSuXig37xx9w2+iRrwXLTVhgg@mail.gmail.com>
Subject: Re: [PATCH] Linux: Add execveat system call wrapper
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org,
 =?UTF-8?Q?Alexandra_H=C3=A1jkov=C3=A1?= <ahajkova@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2021 12:13:28 -0000

Thank you for the review.

> > +  if (WIFEXITED (status))
> > +    {
> > +      if (WEXITSTATUS (status) == EXIT_UNSUPPORTED)
> > +        FAIL_UNSUPPORTED ("execveat is unimplemented");
> > +      else if (expected_fail != 0)
Isn't comparing WEXITSTATUS (status) with 0 sufficient?
> > +        TEST_COMPARE (WEXITSTATUS (status), 0);
> > +      else
> > +        TEST_COMPARE (WEXITSTATUS (status), 3);
> > +    }
>
> Also log a failure for !WIFEXITED (status).

Thank you,
Alexandra