public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] libio: Fix oversized __io_vtables
Date: Fri, 8 Sep 2023 15:54:30 -0400	[thread overview]
Message-ID: <CAD_bs+rT8MtjDOCftmiXkLFhVZGuKsp7u2X8tgtCXV6=dvwvSQ@mail.gmail.com> (raw)
In-Reply-To: <87msxw7vye.fsf@oldenburg.str.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

On Fri, Sep 8, 2023 at 7:20 AM Florian Weimer <fweimer@redhat.com> wrote:

Maybe use [] and
>
> _Static_assert (array_length (__io_vtables) == IO_VTABLES_NUM,
>                 "initializer count);
>
> after the definition?
>
> Let me know if you want to make this change.  I've got a machine
> checkout that can build glibc on all supported architectures fairly
> quickly.
>

Sure. I'll send a new patch, I spotted a grammar-o in the commit message.

- ajax

  reply	other threads:[~2023-09-08 19:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 19:38 Adam Jackson
2023-09-08 11:20 ` Florian Weimer
2023-09-08 19:54   ` Adam Jackson [this message]
2023-09-08 19:55 Adam Jackson
2023-09-08 20:59 ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD_bs+rT8MtjDOCftmiXkLFhVZGuKsp7u2X8tgtCXV6=dvwvSQ@mail.gmail.com' \
    --to=ajax@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).