From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3EF5B3858D1E for ; Fri, 8 Sep 2023 19:54:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3EF5B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694202885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oOsrz99LXrMmTrXQzHvi71TB7hk5ffxWNYOKwvXigXM=; b=NBST6TugPsigaaYHvJjc6gdyvc02f7ETRyQzvf8Alw9rdQU3vOLy/y0KVrFMJJZiB3qFWD P/JMixtTjsz+kaaSCNW6cSzhmzn/EvcguuUcDBlFo/nUzWa28jyHwa62RiV0P00jVLLlxi C14ER8qMwsqW6rLRxsURD1lYV2u0MHM= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-9fH1B3qWOymKFkzRDCTkcg-1; Fri, 08 Sep 2023 15:54:42 -0400 X-MC-Unique: 9fH1B3qWOymKFkzRDCTkcg-1 Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-3a9c59ccbeaso2714456b6e.1 for ; Fri, 08 Sep 2023 12:54:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694202881; x=1694807681; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oOsrz99LXrMmTrXQzHvi71TB7hk5ffxWNYOKwvXigXM=; b=qraVpKGh/MVlGw8LHW1atEKd1MWgGaH0r7TuU5p/Dbr+iuKcYQKuZUV+l4NE7wo+Op 2HFvC0zyuekJYprAc/k3ucJdm38FLHstUT4ztfpjSPj2GmJrkH11lL47PCI81fRddiLx i/UVOTMQ30QT4keJAQyg2sVNQkpRzUyCtxfio4p88pX6waT9Gp+Xa+jxcxn39GbDHGkn SwmKJU/Lw/vUq8SoYiZ+EvCylzWOLYgfMk25G5DTemDj9waPZqk/tMhd91KzOXaTPGkC taiTmXsdsmOCqeEUOKD2MT1/gDFLJzW7KHYqhqsGZSUShY5Brlhr4+iRbX+Vom2cPcsn VjUg== X-Gm-Message-State: AOJu0YzpsSBHb45n53ziIssdzCyNCcDdPG1mjYZHKhK57wr7NryNSHr0 p7HYpelnRTADG1Fk0z+m09wHhXg+nTV97cj7Mcndqw7jXDZFSKnHBNlhpfHQnTg7enX7l1S6YHw +9/Q7tYbEaNccfKKim0AmzxfVeJCV2EYBZCEVNj6R9jJ1 X-Received: by 2002:a05:6808:1589:b0:3a7:56a5:4251 with SMTP id t9-20020a056808158900b003a756a54251mr4550622oiw.16.1694202881573; Fri, 08 Sep 2023 12:54:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErB7wADyM5bgPELhlhl+OVufqt1BbiR2xdaeh3spOHJZ3uwkH9phoqyaYa1UIjzdLGf+4e4PL9j2K1g/zKrUA= X-Received: by 2002:a05:6808:1589:b0:3a7:56a5:4251 with SMTP id t9-20020a056808158900b003a756a54251mr4550614oiw.16.1694202881382; Fri, 08 Sep 2023 12:54:41 -0700 (PDT) MIME-Version: 1.0 References: <20230907193828.126271-1-ajax@redhat.com> <87msxw7vye.fsf@oldenburg.str.redhat.com> In-Reply-To: <87msxw7vye.fsf@oldenburg.str.redhat.com> From: Adam Jackson Date: Fri, 8 Sep 2023 15:54:30 -0400 Message-ID: Subject: Re: [PATCH] libio: Fix oversized __io_vtables To: Florian Weimer Cc: libc-alpha@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000ec31ce0604de5800" X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ec31ce0604de5800 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 8, 2023 at 7:20=E2=80=AFAM Florian Weimer = wrote: Maybe use [] and > > _Static_assert (array_length (__io_vtables) =3D=3D IO_VTABLES_NUM, > "initializer count); > > after the definition? > > Let me know if you want to make this change. I've got a machine > checkout that can build glibc on all supported architectures fairly > quickly. > Sure. I'll send a new patch, I spotted a grammar-o in the commit message. - ajax --000000000000ec31ce0604de5800--