From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 482913858C74 for ; Thu, 12 Jan 2023 17:26:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 482913858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pg1-x530.google.com with SMTP id 36so13231677pgp.10 for ; Thu, 12 Jan 2023 09:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dEXi4mSyxzxrRwOwWgzC4p4iDtdcLekR3XXmlwTSOyA=; b=wYftBVChF5qYqc6CCLu9CpFNGs3NMVC7KG87Nijn/tQFdNl/+OI6Zq1iGXOAO073Xd pRpZlvit9a/T+jQM37H5jteu8SNF98HUhmknadGlJoyOrdJESOUtKowX/jQ+lZcXdLC0 UJ2h6tpbRHe3lpShQen3WLUQzC63INGKUy1CjX/KjlbhDuQITC2HBQlTqfC2IYQKoMom VZRbdKLWFBVCJSldlXZNM0a4kQoRtRzE67PED5I3KvhY4PAbZ+zGKbsruXiiYTnvI6Uk LB3cGSmGkUqidiYdkfxt1vYg5D32/H9jOybVXuTxv3rkzMtJt77UKbzSze9S44HPauzL QA5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dEXi4mSyxzxrRwOwWgzC4p4iDtdcLekR3XXmlwTSOyA=; b=lV10FPvW2HX7X8jCRISBBaQws4kXrBqKlIqWH6G26WqjRV7U1n1qZJO1Rm2K9lPn2S qGjpzjlTQ6SmOJ0tW7xvgLQoDDGHh2Ryuoe6aXdolVqwJLgEchmn30LzuJeDCQOgFbMt 50sy6KVOrQY1CjJaAD2uUm0MxbuKGdimq4TYxPVj8EV/nMoO5WMDT+obh4FVzQ31Pe0+ 3WRSv6wgcTiMohr3tUYs3o3EfQQMVO2VcfNHPD+FnOAMYdZTk88/mG5zMDBcV2EfyDV3 rNC8K6TWKHJve8J2udhipWtFnmOZ5LAKa3g5O9eLhY4Lp35QnlzDAdKvrLPyVynPxtCV Du/g== X-Gm-Message-State: AFqh2kq9BM4zeDcsHvwabB0M5P8u4BicRWiqGuITtUdA0mGbD9WTN+Jc oEJu+8A6pAGJAnspw080N0a5KOvzj4hX5XPD80d3Jw== X-Google-Smtp-Source: AMrXdXtcyn1YXPNWaqlFEAlTfz89S5khnnv6mUUG1SKZZuCv9s/JqhHdiNXtBodYIZm3wv8nfxrwT/kpDijrqXpTXtw= X-Received: by 2002:a05:6a00:1506:b0:575:2199:70e8 with SMTP id q6-20020a056a00150600b00575219970e8mr6029806pfu.14.1673544398135; Thu, 12 Jan 2023 09:26:38 -0800 (PST) MIME-Version: 1.0 References: <20230111204558.2402155-1-adhemerval.zanella@linaro.org> <20230111204558.2402155-10-adhemerval.zanella@linaro.org> In-Reply-To: <20230111204558.2402155-10-adhemerval.zanella@linaro.org> From: Carlos Seo Date: Thu, 12 Jan 2023 14:26:26 -0300 Message-ID: Subject: Re: [PATCH v7 09/17] string: Improve generic strcmp To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Noah Goldstein , Richard Henderson Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 11 Jan 2023 at 17:48, Adhemerval Zanella via Libc-alpha wrote: > > From: Adhemerval Zanella Netto > > +static inline int > +final_cmp (const op_t w1, const op_t w2) > +{ > + /* It can not use index_first_zero_ne because it must not compare past the > + final '/0' is present (and final_cmp is called before has_zero check). > + */ Minor comment typo: '\0'