From: Carlos Seo <carlos.seo@linaro.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org,
Richard Henderson <richard.henderson@linaro.org>,
Noah Goldstein <goldstein.w.n@gmail.com>
Subject: Re: [PATCH 1/3] string: Add libc_hidden_proto for strchrnul
Date: Wed, 8 Feb 2023 16:52:45 -0300 [thread overview]
Message-ID: <CADv_rEJXjMajb75N=xLfxTVRw1kXbb2S04h4cYZTv6iSGFT0+Q@mail.gmail.com> (raw)
In-Reply-To: <CADv_rELeKS1BVtpnoV0mLcxC4NacNi84SwfpZ4=Cj74tXLptkg@mail.gmail.com>
Reviewed-by: Carlos Eduardo Seo <carlos.seo@linaro.org>
On Wed, 8 Feb 2023 at 14:14, Carlos Seo <carlos.seo@linaro.org> wrote:
>
> On Tue, 7 Feb 2023 at 10:14, Adhemerval Zanella via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
> >
> > Although static linker can optimize it to local call, it follow the
> > internal scheme to provide hidden proto and definitions.
> > ---
>
> Just a typo in the commit message (s/follow/follows/), otherwise, LGTM.
next prev parent reply other threads:[~2023-02-08 19:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 13:12 [PATCH 0/3] Minor fixes from generic string routines Adhemerval Zanella
2023-02-07 13:12 ` [PATCH 1/3] string: Add libc_hidden_proto for strchrnul Adhemerval Zanella
2023-02-08 17:14 ` Carlos Seo
2023-02-08 19:52 ` Carlos Seo [this message]
2023-02-07 13:12 ` [PATCH 2/3] string: Add libc_hidden_proto for memrchr Adhemerval Zanella
2023-02-08 17:15 ` Carlos Seo
2023-02-08 19:52 ` Carlos Seo
2023-02-07 13:12 ` [PATCH 3/3] string: Disable stack protector in early static initialization Adhemerval Zanella
2023-02-08 17:27 ` Carlos Seo
2023-02-08 19:53 ` Carlos Seo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADv_rEJXjMajb75N=xLfxTVRw1kXbb2S04h4cYZTv6iSGFT0+Q@mail.gmail.com' \
--to=carlos.seo@linaro.org \
--cc=adhemerval.zanella@linaro.org \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).