From: "罗勇刚(Yonggang Luo)" <luoyonggang@gmail.com>
To: Zack Weinberg <zack@owlfolio.org>
Cc: Jens Gustedt <jens.gustedt@inria.fr>,
GNU libc development <libc-alpha@sourceware.org>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH v2 1/4] clang-format: should format with 2 space and do not usage tab
Date: Wed, 21 Jun 2023 14:31:55 +0800 [thread overview]
Message-ID: <CAE2XoE-T4YtZ4uZVq2-tVmFSZhQzXCHNzqh7RE71NUr6TuDvDg@mail.gmail.com> (raw)
In-Reply-To: <2c0b7268-4efd-4ace-beef-9155501ed700@app.fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]
On Wed, Jun 21, 2023 at 1:45 AM Zack Weinberg <zack@owlfolio.org> wrote:
>
> On Tue, Jun 20, 2023, at 1:17 PM, Yonggang Luo via Libc-alpha wrote:
> > -TabWidth: 8
> > -UseTab: Always
> > +TabWidth: 2
> > +UseTab: Never ForEachMacros:
>
> This is not right. GNU style is two spaces per *indent level*, but you
> *are* supposed to use hard tabs to compress all runs of 8*n spaces at
I am trying to stop using Tab in the code base, so I don't understand
what's your
concern, before the patch, the clang-format tried to use an 8 spaces width
tab to indent code.
After this patch, the clang-patch always uses 2 spaces to indent code.
> the beginning of a line, regardless of the semantics of the spaces (i.e.
> unlike some other styles, it doesn't matter whether the spaces represent
> nesting or alignment). I *thought* this was documented somewhere in
> https://www.gnu.org/prep/standards/html_node/ but I can't find it (but I
> have personally been yelled at on this very mailing list for screwing it
> up, so I don't want you to have the same experience).
>
> Whether clang-format can do this correctly, I do not know.
>
> zw
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
next prev parent reply other threads:[~2023-06-21 6:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 17:17 [PATCH v2 0/4] c2y proposal add monotonicwait support for mtx and ctx Yonggang Luo
2023-06-20 17:17 ` [PATCH v2 1/4] clang-format: should format with 2 space and do not usage tab Yonggang Luo
2023-06-20 17:45 ` Zack Weinberg
2023-06-21 6:31 ` 罗勇刚(Yonggang Luo) [this message]
2023-06-21 6:47 ` Xi Ruoyao
2023-06-21 6:55 ` 罗勇刚(Yonggang Luo)
2023-06-21 7:13 ` Xi Ruoyao
2023-06-21 7:36 ` 罗勇刚(Yonggang Luo)
2023-06-21 14:26 ` Zack Weinberg
2023-06-21 7:17 ` Xi Ruoyao
2023-06-21 16:19 ` Carlos O'Donell
2023-06-21 17:35 ` Joseph Myers
2023-06-21 17:41 ` 罗勇刚(Yonggang Luo)
2023-06-21 17:49 ` Andrew Pinski
2023-06-21 17:59 ` 罗勇刚(Yonggang Luo)
2023-06-21 18:31 ` Arsen Arsenović
2023-06-21 18:42 ` 罗勇刚(Yonggang Luo)
2023-06-21 19:36 ` Zack Weinberg
2023-06-21 21:26 ` Paul Eggert
2023-06-22 21:43 ` Joseph Myers
2023-06-22 21:48 ` Paul Eggert
2023-06-20 17:17 ` [PATCH v2 2/4] time: Implement c23 timespec_get base Yonggang Luo
2023-06-20 20:37 ` Joseph Myers
2023-06-21 6:42 ` 罗勇刚(Yonggang Luo)
2023-06-20 17:17 ` [PATCH v2 3/4] c11: Switch to use pthread_mutex_clocklock and pthread_cond_clockwait to implement cnd and mtx lock and wait Yonggang Luo
2023-06-20 17:17 ` [PATCH v2 4/4] c2y: Add function cnd_timedwait_base and mtx_timedlock_base Yonggang Luo
2023-06-20 20:41 ` Joseph Myers
2023-06-21 9:21 ` 罗勇刚(Yonggang Luo)
2023-06-21 9:54 ` Xi Ruoyao
2023-06-21 10:16 ` 罗勇刚(Yonggang Luo)
2023-06-21 10:25 ` Xi Ruoyao
2023-06-21 10:40 ` Florian Weimer
2023-06-21 13:23 ` Jₑₙₛ Gustedt
2023-06-21 12:09 ` Joseph Myers
2023-06-21 14:30 ` enh
2023-06-21 15:08 ` Joseph Myers
2023-06-21 18:39 ` 罗勇刚(Yonggang Luo)
2023-06-21 19:04 ` enh
2023-06-21 19:07 ` 罗勇刚(Yonggang Luo)
2023-06-21 19:18 ` enh
2023-06-21 19:38 ` 罗勇刚(Yonggang Luo)
2023-06-21 19:41 ` enh
2023-06-21 20:14 ` 罗勇刚(Yonggang Luo)
2023-06-21 19:43 ` 罗勇刚(Yonggang Luo)
2023-06-20 20:50 ` Joseph Myers
2023-06-20 20:45 ` [PATCH v2 0/4] c2y proposal add monotonicwait support for mtx and ctx Joseph Myers
2023-06-21 6:52 ` 罗勇刚(Yonggang Luo)
2023-06-21 7:14 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE2XoE-T4YtZ4uZVq2-tVmFSZhQzXCHNzqh7RE71NUr6TuDvDg@mail.gmail.com \
--to=luoyonggang@gmail.com \
--cc=fweimer@redhat.com \
--cc=jens.gustedt@inria.fr \
--cc=libc-alpha@sourceware.org \
--cc=zack@owlfolio.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).