On Wed, Jun 21, 2023 at 2:47 PM Xi Ruoyao wrote: > > On Wed, 2023-06-21 at 14:31 +0800, 罗勇刚(Yonggang Luo) via Libc-alpha wrote: > > On Wed, Jun 21, 2023 at 1:45 AM Zack Weinberg wrote: > > > > > > On Tue, Jun 20, 2023, at 1:17 PM, Yonggang Luo via Libc-alpha wrote: > > > > -TabWidth: 8 > > > > -UseTab: Always > > > > +TabWidth: 2 > > > > +UseTab: Never ForEachMacros: > > > > > > This is not right. GNU style is two spaces per *indent level*, but you > > > *are* supposed to use hard tabs to compress all runs of 8*n spaces at > > > > I am trying to stop using Tab in the code base, so I don't understand > > what's your > > concern, before the patch, the clang-format tried to use an 8 spaces width > > tab to indent code. > > After this patch, the clang-patch always uses 2 spaces to indent code. > > Because the existing code uses one tab for 8 spaces. Glibc has its own > coding standard, not "what you prefer". I am also talking about the existing code, so the conclusion is the existing code is not consistent, some use one tab for 8 spaces, some use spaces directly > > -- > Xi Ruoyao > School of Aerospace Science and Technology, Xidian University -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo