From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fantasquex@gmail.com>
Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31])
	by sourceware.org (Postfix) with ESMTPS id EDDA63856DC0
	for <libc-alpha@sourceware.org>; Fri, 21 Oct 2022 15:02:23 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EDDA63856DC0
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-1322d768ba7so3870014fac.5
        for <libc-alpha@sourceware.org>; Fri, 21 Oct 2022 08:02:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=YRv9MJ0TunsZMEwdeGMg32EkRCUEz8y+ylmN1GvatJc=;
        b=BfKbhB7EPM5eeStutVSO91DRc0L2eyp3JGq5NvaxYnRRKIJxefAJjexDzHJFlUUgGW
         iQWs74TE4IPMIOlMvUCvYeE0zdCPcwr5kbswdQS9hzWMLydmamvGjCUk9BA1Y8YzNVFy
         c36zh+A2Tg3SEymd3nTVp/5/tVlF7oHKsh1BHpYIjKyN7hlbNisEMVIfpkm7ZRr39E2s
         jI//x7XIxWSfQWHewjlpAnSkFAFSdsyA0gEGU7WKw/yOwn5TTT9Fr4eWRF85klmp/Sqw
         r4xHPwwr0MjLHwdjBSKzCA2eWb0EWBcOq1SyLH5K6whDXjQaTIbBKNk+QS1kOgHygJSX
         OIkg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=YRv9MJ0TunsZMEwdeGMg32EkRCUEz8y+ylmN1GvatJc=;
        b=Fk2JXgDDQkaIJ4K0Za4FA+JYoHC+SxamsgpYmpU9OLaBSOicQFSEB9sy0lMqgc6C3m
         QQkZ8pbEMulJK5vCcY2N/4KnRPuyB/c0PWNS99GrvEEQ3/+115Wte7uR6OQ42OCdHLC9
         qGkG3WiHT7hX/DI+QAwlv3CaHCDHYYJHTiFzuoAUTP0BIcwkrAplIJWmH6SEriYLWsNf
         fqmz+LzjdeqIYxbdTBmPJ0Bu7i0m53HbVy/vN6V2VzNsnYM0CBKnVILqmNzUvo89MTY3
         /5Gk7/a0ERsd4jwcZXhFCH78p7dFn3WY1a/lfiYUHd/GMEanPK7LAqDxXAK12yA5AFar
         Bg8A==
X-Gm-Message-State: ACrzQf2FM5ptyheXz9JRYBPxgzTRS2nII4ifTJXKqNyY0+Q3E1pqOi0B
	ARL6+GEhz8vU4VTtyHCdxH5FZ3xEbrt65LnMj/0UI+90vO6vH8GDkefY6g==
X-Google-Smtp-Source: AMsMyM7wQlRyC1EtqgBbC59Ef1ubv6PeT5HEY9dnyRxAv7VW3Izi67ywIKsDiBB1A/lil4xAomg0lsY8o6IBkCJSjWg=
X-Received: by 2002:a17:90b:1b08:b0:20d:7bbf:4701 with SMTP id
 nu8-20020a17090b1b0800b0020d7bbf4701mr58680536pjb.87.1666364520883; Fri, 21
 Oct 2022 08:02:00 -0700 (PDT)
MIME-Version: 1.0
References: <20221006150137.18691-1-fantasquex@gmail.com> <2618159f-b3f2-3819-5817-e5f02490350a@linaro.org>
In-Reply-To: <2618159f-b3f2-3819-5817-e5f02490350a@linaro.org>
From: Letu Ren <fantasquex@gmail.com>
Date: Fri, 21 Oct 2022 23:01:59 +0800
Message-ID: <CAEUwDuCnsEW+TTJhvgkvrZNVkaRWk_hmPXfEFn9gvT=Voq=6pA@mail.gmail.com>
Subject: Re: [PATCH v5] stdlib/strfrom: Add copysign to fix NAN issue on riscv
 (BZ #29501)
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, fweimer@redhat.com, schwab@suse.de, 
	joseph@codesourcery.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

Hi,

First, thanks for your reply.

> The fix-float-double-convert-nan.h misses the Copyright headers, otherwise
> LGTM.
> It is missing the usual Copyright as for other fix-* files.

Yes. As I mentioned in the comment, I left copyright because I'm not
familiar with it and don't find one in the maintenance part of glibc
manual. I just copy copyright part of other files in glibc, I hope I
didn't screw this up. Could you please review my v6 patch which fix
copyright issue? Thanks.

Regards
Letu Ren