From: Letu Ren <fantasquex@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v2] stdlib/strfrom: Change -NAN test to multiple possible results (bug 29501)
Date: Sun, 18 Sep 2022 16:54:12 +0800 [thread overview]
Message-ID: <CAEUwDuDKLWDLN=5KCbJ=Aqx4ZPgGX9VzO3PRiRmqJYuWJ1aGiQ@mail.gmail.com> (raw)
In-Reply-To: <87tu5584od.fsf@oldenburg.str.redhat.com>
On Sun, Sep 18, 2022 at 4:31 PM Florian Weimer <fweimer@redhat.com> wrote:
>
> I think the conversion to double is required because according to the
> quote from ISO/IEC TS 18661-1:2014 in the bug, strfromf is defined in
> terms of snprintf, and calling snprintf promotes float arguments that do
> not correspond to a declared parameter to double as part of the default
> argument promotions.
>
> (Admittedly, this could be a bug in the TS.)
I agree with you that the conversion is required. The problem is that those
standards don't define whether we should keep the signbit of -NAN explicitly.
Joseph thinks we should keep the behavior of glibc consistent across
different architectures and keep the signbit explicitly, while I think
the signbit
doesn't really matter originally. Since I'm not familiar with glibc, I
would like to
hear from more people. How do you think this problem should be solved?
Just like what Joseph says or something else?
Thanks,
Letu Ren
next prev parent reply other threads:[~2022-09-18 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 6:13 Letu Ren
2022-09-18 5:32 ` Joseph Myers
2022-09-18 8:31 ` Florian Weimer
2022-09-18 8:54 ` Letu Ren [this message]
2022-09-18 16:25 ` Joseph Myers
2022-09-19 7:38 ` Florian Weimer
2022-09-21 10:36 ` Letu Ren
2022-09-21 16:34 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEUwDuDKLWDLN=5KCbJ=Aqx4ZPgGX9VzO3PRiRmqJYuWJ1aGiQ@mail.gmail.com' \
--to=fantasquex@gmail.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).