From: Letu Ren <fantasquex@gmail.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, fweimer@redhat.com,
joseph@codesourcery.com, schwab@suse.de
Subject: Re: [PATCH v6] stdlib/strfrom: Add copysign to fix NAN issue on riscv (BZ #29501)
Date: Sat, 22 Oct 2022 12:43:40 +0800 [thread overview]
Message-ID: <CAEUwDuDhUo1Esm+EWFUQm8+qRky4kXK+GLJuM1mKPFT5mCoOXg@mail.gmail.com> (raw)
In-Reply-To: <9f0725fe-98b0-0b9e-1bd8-e51275ad5561@linaro.org>
> LGTM, thanks. Really minor nits below that I did not catch before, there is no
> need to send a v7 (just fix it before install).
Thanks for your review!
> Double space after period.
>
> Double space before close comment.
>
> Double space after period and remove last final period.
I will pay attention to these style problems next time.
Regards
Letu Ren
next prev parent reply other threads:[~2022-10-22 4:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 14:54 Letu Ren
2022-10-21 17:10 ` Adhemerval Zanella Netto
2022-10-22 4:43 ` Letu Ren [this message]
2022-10-28 14:26 ` Letu Ren
2022-10-28 14:32 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEUwDuDhUo1Esm+EWFUQm8+qRky4kXK+GLJuM1mKPFT5mCoOXg@mail.gmail.com \
--to=fantasquex@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).