From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 1C29B38185DE for ; Fri, 16 Sep 2022 11:06:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C29B38185DE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52c.google.com with SMTP id 78so20007651pgb.13 for ; Fri, 16 Sep 2022 04:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=IfOKFzfM+h74BqjLrO/tF9625ZABzueNnkyjPIqrU3c=; b=CdLnw+n/JWyQYFB934GJP1LA5kbnjMKl45rgKpdpQuxR9T+7ie5Ta6LIMtH9Ni38AK UzGg26qcVK/awM/6XzKy63PZomOZnWEArowkRZ1y6gpwGhyzyLJpp4GKKhOz7wr3z3dD 0no8garbJ2dpATnLeDPBIHyxVvYDsDGynR8YPD+mat78ocUMUBsdVKNYZ08IQExPxsuO SlGE5zOu9YzWX1fNLHBMMw/c7QMaSS21nkFbGddvKRmQFXKVj0YvC2yQMZ+i3tt/debq aeUmuxdBWPCgIh3TwBqA3/PuIj6kwk1RMoX/l5WoVdfN1X3QBMWktYyL9O22+w+kkxHw 9RXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=IfOKFzfM+h74BqjLrO/tF9625ZABzueNnkyjPIqrU3c=; b=ElBLRezl2OJeWwCqj81G92DpYNXUWaokqbyZGJltmzq8jCRD06vwQ9pstzMrPrv5/A 0xbtjJrCRZIcB94oBhHbOdglAAe0n+JN1qV2Umq9L8rI+0knI0vFBaH73hxtFISPSS1o 6+76kTJ6Sg78qYvsdvheH6OFOEj4KSPByB1F7wyiSQKhP+aDANTXLaQ41U6w3rBg1IIj qWx7JSmQzMvR3FbZOGfoZy97yGjo3BY48i/vRggXZFrf4Ydn7n8El6xX9MCvMNxmuTnk ckq7zxuCx9e/XhUbERSh2vycLfII2k1JUy/SuPFOc/X7qJ7a/5E0e0kpE1575GD1yqo/ ZTbQ== X-Gm-Message-State: ACrzQf0Az1b21NWtc4lF4KLSgGqW/uzLuUINnbYExZw2zowJ9LlaSz0b a9J9ZH595tjkLvrD8pz3u8CDP3oQ7nJbnqzCAJaEJOocM4nGEg== X-Google-Smtp-Source: AMsMyM51oI6ozzC81mhJGOzBk+aKTeTotWwXQUcUUChqiBwMWaBlxT7Kyi61eAezCZXGFzHauW6+Qu376y73jg0fcC0= X-Received: by 2002:a05:6a00:1248:b0:548:2e34:65e1 with SMTP id u8-20020a056a00124800b005482e3465e1mr4328555pfi.82.1663326402104; Fri, 16 Sep 2022 04:06:42 -0700 (PDT) MIME-Version: 1.0 References: <20220915174421.4414-1-fantasquex@gmail.com> <87h717zlv9.fsf@oldenburg.str.redhat.com> In-Reply-To: <87h717zlv9.fsf@oldenburg.str.redhat.com> From: Letu Ren Date: Fri, 16 Sep 2022 19:06:32 +0800 Message-ID: Subject: Re: [PATCH] stdlib/strfrom: Remove the -NAN testcase (bug 29501) To: Florian Weimer Cc: Letu Ren via Libc-alpha Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Shouldn't the test verify that the result is "NAN" or "-NAN"? That part > is still valid. Yes, I agree with you. Testing whether NAN is implemented correctly is needed. The hard part is how to change the code. Currently, tests are generated using macro. I'm not pretty sure how to adjust code that generates tests. Two probable results or an array? Maybe another test array instead of existing tests, stest, htest? Now, I think a proper way might be changing this test to NAN, and adding another class of test which accepts two possible results to test -NAN. If you think that is OK, I would like to send another patch v2. Thanks for your review! Letu Ren.