From: Matt Turner <mattst88@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Florian Weimer <fweimer@redhat.com>,
Zack Weinberg <zackw@panix.com>,
GNU C Library <libc-alpha@sourceware.org>,
Roland McGrath <roland@hack.frob.com>
Subject: Re: [PATCH 2/2] Remove vestiges of NaCl port from ARM assembly files.
Date: Sat, 20 May 2017 21:39:00 -0000 [thread overview]
Message-ID: <CAEdQ38FrxyuYB6B4MQ5k_AvPRbV_hu5Q9rnfPOo81R_2XAPC4w@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1705121403150.13203@digraph.polyomino.org.uk>
On Fri, May 12, 2017 at 7:09 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Fri, 12 May 2017, Florian Weimer wrote:
>
>> On 05/12/2017 02:37 AM, Zack Weinberg wrote:
>> > This semi-mechanical patch removes all uses and definitions of the
>> > sfi_breg, sfi_pld, and sfi_sp macros from various ARM-specific
>> > assembly files. These were only used by NaCl. Please read carefully,
>> > I don't have any ARM hardware to test this patch on and I may have
>> > screwed up my regular expressions.
>>
>> I did a build on an armv7l-redhat-linux-gnueabihf system, and the libc.so.6
>> file had identical disassembly before and after the build, so I assume that
>> this is okay.
>
> Yes, it's OK given that testing and the removal of the NaCl port itself.
>
> (There are several other defines in sysdeps/arm/nacl/arm-features.h that
> are never defined for non-NaCl, or have constant definitions for non-NaCl
> - ARM_ALWAYS_BX, ARM_BX_ALIGN_LOG2, ARM_NO_INDEX_REGISTER - and which
> should probably be cleaned up as well eventually in separate patches, but
> the sfi_* are by far the most invasive. ARM_ASSUME_NO_IWMMXT is only
> defined for NaCl at present, but logically could be defined for all builds
> for ARMv6 and later (__ARM_ARCH >= 6, given GCC 4.8 or later or the
> __ARM_ARCH emulation in sysdep.h) as iWMMXt is only on certain v5TE
> processors. NO_THUMB is more complicated in that only NaCl defines it in
> arm-features.h, but some individual .S files define it as well.)
Some Marvell CPUs have iwMMXt, like the one in the OLPC XO 1.75. It's am ARMv7.
next prev parent reply other threads:[~2017-05-20 21:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 0:38 [PATCH 1/2] Remove the bulk of the NaCl port Zack Weinberg
2017-05-12 0:38 ` [PATCH 2/2] Remove vestiges of NaCl port from ARM assembly files Zack Weinberg
2017-05-12 8:22 ` Florian Weimer
2017-05-12 14:09 ` Joseph Myers
2017-05-12 14:30 ` Zack Weinberg
2017-05-20 12:15 ` Zack Weinberg
2017-05-12 15:01 ` Florian Weimer
2017-05-20 21:39 ` Matt Turner [this message]
2017-05-22 14:54 ` Joseph Myers
2017-05-12 6:21 ` [PATCH 1/2] Remove the bulk of the NaCl port Florian Weimer
2017-05-27 10:08 ` Rical Jasan
2017-05-27 15:20 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEdQ38FrxyuYB6B4MQ5k_AvPRbV_hu5Q9rnfPOo81R_2XAPC4w@mail.gmail.com \
--to=mattst88@gmail.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=roland@hack.frob.com \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).