From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23358 invoked by alias); 20 May 2017 21:39:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 23340 invoked by uid 89); 20 May 2017 21:39:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=H*Ad:U*roland, ARMv7 X-HELO: mail-yw0-f178.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ybiE3OTzCtp8PZfeazt063VAwV7DYFjxHDdAJSsEp1Q=; b=uTW2ZQ1oE5Vg5NINVrPziB/ZxJ59xezOC1og4tT1eYzazu4zZpXExIQLDZK38FEe8k f8iG2+sAMVORut+jDns8c7bLcmxxguKtx3VLxX6wlxq+vjJwrfQkx6uTbsU4aiILuHvH ZNVSRYq4WmKYiKZbjtKCw/GFz0mXK6yHcu1r00xoDLmdY9k5ZsLvSQXW94cUeBf0Wk0/ L9RXZ4EfMuZHk6P+s1Lz+yu0/ZV2Yb3CJlqu3j9VxOPIToN3CNQnw+vLd1uSKzaS1mEB Pf4EMEeY7pub5P+wBB/yLQa0s/ixgNAX5W81M+MTfOh9BYBImWl3fd7JBhus6FHP7EUf kcrQ== X-Gm-Message-State: AODbwcDF9+PeyqXRmruKWL2sIXe3chGtvniV/dX93ToG6UstFjbKT67V 1U0QoD7AUnSmMRjWpUGN1r7fCDFM3+kK X-Received: by 10.129.83.5 with SMTP id h5mr6606104ywb.234.1495316361889; Sat, 20 May 2017 14:39:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20170512003750.27215-1-zackw@panix.com> <20170512003750.27215-2-zackw@panix.com> <8f3bad76-14a6-5d5c-9a3b-e6e94beef5f8@redhat.com> From: Matt Turner Date: Sat, 20 May 2017 21:39:00 -0000 Message-ID: Subject: Re: [PATCH 2/2] Remove vestiges of NaCl port from ARM assembly files. To: Joseph Myers Cc: Florian Weimer , Zack Weinberg , GNU C Library , Roland McGrath Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-05/txt/msg00632.txt.bz2 On Fri, May 12, 2017 at 7:09 AM, Joseph Myers wrote: > On Fri, 12 May 2017, Florian Weimer wrote: > >> On 05/12/2017 02:37 AM, Zack Weinberg wrote: >> > This semi-mechanical patch removes all uses and definitions of the >> > sfi_breg, sfi_pld, and sfi_sp macros from various ARM-specific >> > assembly files. These were only used by NaCl. Please read carefully, >> > I don't have any ARM hardware to test this patch on and I may have >> > screwed up my regular expressions. >> >> I did a build on an armv7l-redhat-linux-gnueabihf system, and the libc.so.6 >> file had identical disassembly before and after the build, so I assume that >> this is okay. > > Yes, it's OK given that testing and the removal of the NaCl port itself. > > (There are several other defines in sysdeps/arm/nacl/arm-features.h that > are never defined for non-NaCl, or have constant definitions for non-NaCl > - ARM_ALWAYS_BX, ARM_BX_ALIGN_LOG2, ARM_NO_INDEX_REGISTER - and which > should probably be cleaned up as well eventually in separate patches, but > the sfi_* are by far the most invasive. ARM_ASSUME_NO_IWMMXT is only > defined for NaCl at present, but logically could be defined for all builds > for ARMv6 and later (__ARM_ARCH >= 6, given GCC 4.8 or later or the > __ARM_ARCH emulation in sysdep.h) as iWMMXt is only on certain v5TE > processors. NO_THUMB is more complicated in that only NaCl defines it in > arm-features.h, but some individual .S files define it as well.) Some Marvell CPUs have iwMMXt, like the one in the OLPC XO 1.75. It's am ARMv7.