From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mattst88@gmail.com>
Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com
 [IPv6:2a00:1450:4864:20::52d])
 by sourceware.org (Postfix) with ESMTPS id 2F3D7385BF92
 for <libc-alpha@sourceware.org>; Thu,  2 Apr 2020 23:05:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2F3D7385BF92
Received: by mail-ed1-x52d.google.com with SMTP id de14so6744196edb.4
 for <libc-alpha@sourceware.org>; Thu, 02 Apr 2020 16:05:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=cwnjsyQIrTIXmoNDrQXHMJmNjj80fmtoGxD9u/x/fJU=;
 b=KsTw40gO9+gJvgJHyl3Dc4TZXOJ8kb/3jtgqWabbabWAjdKX8J1xYr9Iip8EqLbRoe
 DOW8gHROevZPD1+0kh7Hwhzow/5FCCAmdyK/kGmJT4bDmwfJ0iD48ZlNQqHQiSWO/GEa
 +wbZg6KYh6CmAsXQWLJg6AMJTcJTpDC4ls8ICSnei2+aE3ED/snpOl5UI+ab0lwaxKgV
 fF5hT2kpnECgsp5kgvShlxIcpraf6zu4uEjdWTGAv6gvRgxMc2A0mj1Mwai77JyiE/T3
 lEpiFqGqUocJBTWMVhz5FgJlyAz8mewU8gVaiWlC6eG+ANBAGksg87+AfU7fAYZO6Yao
 1uxQ==
X-Gm-Message-State: AGi0PuZI9tprtkU9+I03x/dHaMsmx2GVdxsGUIjmBJ31dbtUZsHHM7h5
 yv/heHR3bCSpuSGnvfQ9TVDRXrG8kowdxnDdJeqTLqFvPTg=
X-Google-Smtp-Source: APiQypK70Dpz0DCm2Y5lY7x9l51ISyHw/tHAap1SZoFgYqvK3ib7AsK38PB4MjObvK7L8kvASu6WA45hcME9LybCmQM=
X-Received: by 2002:a17:906:6b10:: with SMTP id
 q16mr5663267ejr.170.1585868734162; 
 Thu, 02 Apr 2020 16:05:34 -0700 (PDT)
MIME-Version: 1.0
References: <22b2c728-6634-9a3f-0752-183e3b83f0d3@redhat.com>
 <xnsghnf17l.fsf@greed.delorie.com> <87mu7vvvqw.fsf@igel.home>
In-Reply-To: <87mu7vvvqw.fsf@igel.home>
From: Matt Turner <mattst88@gmail.com>
Date: Thu, 2 Apr 2020 16:05:22 -0700
Message-ID: <CAEdQ38G7sfKL7QqAfr0H9DcseKF3Fp155Cd5MaHcZPrXKQ+PDQ@mail.gmail.com>
Subject: Re: "make check" times
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: DJ Delorie via Libc-alpha <libc-alpha@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-23.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT,
 FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Apr 2020 23:05:36 -0000

On Wed, Apr 1, 2020 at 12:42 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Apr 01 2020, DJ Delorie via Libc-alpha wrote:
>
> > diff --git a/scripts/merge-test-results.sh b/scripts/merge-test-results.sh
> > index 573a44d8cf..6fd0a28dc8 100755
> > --- a/scripts/merge-test-results.sh
> > +++ b/scripts/merge-test-results.sh
> > @@ -35,7 +35,11 @@ case $type in
> >      subdir=${subdir:+$subdir/}
> >      for t in "$@"; do
> >        if [ -s "$objpfx$t.test-result" ]; then
> > -     head -n1 "$objpfx$t.test-result"
> > +     # This loop is called thousands of times even when there's
> > +     # nothing to do.  Avoid using non-built-in commands (like
> > +     # /bin/head) where possible.
> > +     read line <"$objpfx$t.test-result"
> > +     echo $line
>
> Please use proper quoting.

I see a lot of replies from you (like this) that read as very aloof.
Just from a pragmatic perspective, explaining what you mean initially
would save you the inevitable round-trip.