From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-78443-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 69612 invoked by alias); 5 Apr 2017 11:01:58 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 69598 invoked by uid 89); 5 Apr 2017 11:01:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:864
X-HELO: mail-it0-f68.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=e8lboyf2zOzfFHENgKoL4u1/kMvfolBFAG+Vci16H3A=;
        b=dEOSaua1tdyMjN2wfedcFrhjzSglkSZcSJsp8BvMcH7okaS5g6jN6z2nMIxA5nqnBt
         Sdu+A4+FYkRE7hNg7ht6eZHD5aNXQ4+X86iy6zadKU1N0yATDgz729fUhn/BEyZ7wEbi
         O0RP5jiXVum6/HciRD37dScy0npNVvp6EkPjLibWAR6TjoGhbDPt5OhsC2j/e1kvd6ZN
         W2rcOpdg6fhXEsRD5eEqNNxoONw0Sg4C7gT+NxxMiGvmx/RPh6jmsZVshEkVQSHd8fs/
         qgaP0kTfJcykYsFKrujxrBgTHX8nP9wOR58Vp6t4EHADpVywz1Q+EHJ69jStlBlnVm1x
         ljNg==
X-Gm-Message-State: AFeK/H1JfF/v3c/JR+S2YLP0wqMQKA+l4gCUt7bbI2Y0EutacVTOe0oZ9nKxdxn3C0qENg==
X-Received: by 10.36.220.6 with SMTP id q6mr19975612itg.77.1491390116132;
        Wed, 05 Apr 2017 04:01:56 -0700 (PDT)
X-Received: by 10.107.134.146 with SMTP id q18mr26768024ioi.227.1491390115251;
 Wed, 05 Apr 2017 04:01:55 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <ce204caa-739f-307b-bc44-f3d17f27e55e@redhat.com>
References: <20170405054116.9007-1-quae@daurnimator.com> <ce204caa-739f-307b-bc44-f3d17f27e55e@redhat.com>
From: Daurnimator <quae@daurnimator.com>
Date: Wed, 05 Apr 2017 11:01:00 -0000
X-Gmail-Original-Message-ID: <CAEnbY+dyj535NeaOz6EbVU6od3JKV+61PTWx7EXbXeZHCa5G6g@mail.gmail.com>
Message-ID: <CAEnbY+dyj535NeaOz6EbVU6od3JKV+61PTWx7EXbXeZHCa5G6g@mail.gmail.com>
Subject: Re: [PATCH v3][BZ 21340] add support for POSIX_SPAWN_SETSID
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2017-04/txt/msg00069.txt.bz2

On 5 April 2017 at 18:34, Florian Weimer <fweimer@redhat.com> wrote:
> On 04/05/2017 07:41 AM, daurnimator wrote:
>
>> +static int
>> +do_test (void)
>> +{
>> +  posix_spawnattr_t attrp;
>> +  int res;
>> +  int child_pid;
>> +  int sid, child_sid;
>> +  char *args[2];
>
>
> Thanks for writing the test.  There are some style issues.  We prefer
> in-line declarations these days

Do you mean putting 'static int do_test (void) {' on one line?

> and there should be a space before =E2=80=9C(=E2=80=9D in a
> function call.

There already was?

> Please use the new test skeleton in <support/test-driver.c>.  (Sorry, sti=
ll
> need to update the wiki.)

I just worked from the existing test 'tst-posix_spawn-fd.c'.

> You aren't listed in MAINTAINERS on the wiki.  Do you have a GNU copyright
> assignment on file?

I do not.