From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by sourceware.org (Postfix) with ESMTPS id 6E3D83858401 for ; Wed, 10 Aug 2022 07:09:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6E3D83858401 Received: by mail-yb1-xb29.google.com with SMTP id 199so21872517ybl.9 for ; Wed, 10 Aug 2022 00:09:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=R/RXBzNhu3HYBDXTmscPrQxKQnTkh2GKMz0iAN4Fz0Y=; b=HFldxvpmWZxFsGBfe+AAx3fdYPC34QUN3sHzIxwneNmYCkvcpxYMW8px5/FewseGKQ jFSmns7VQ2/wwtWdjPigh3/6vB/HkIkJ5sxve0UVe9TO8kPWWfmC6OGbpkD6IOU8v9QQ kGR7Nf5phEFlk6ekqMho+/n3RA+uXFS6EbirdrOBi2VpapRMrZzJiZ7xdSTMEnhVVDhi 7i5QMZxpwxYwWEHIfrBZP3N/CboXZtyVJfS2s64g5t3N20AaTpsoyzWzAJcaIXaxZJ2U rI5BrdcAw+lgszqg/Q2uNWPjKc5lqVImfJQMFRu7jyCf9z57C6PEMfz8s5tw4PxAklzT XALg== X-Gm-Message-State: ACgBeo0mOwK3WwmFu2l4rAb8kDncuD53m1tezA9MSPJ8cclkBcOXDAZ2 eoM3BdMnKE2vv/GUd0p0LYWjabt2PKdbVCRnpSlnnQ== X-Google-Smtp-Source: AA6agR7AZnP6+SzqVAJNeYXi6wAczByPZVhtl1s5x2sZ0g2zlMELDudE0DyBDbcg7HT/TksIZs4phX2rdZ25sgL3Zv0= X-Received: by 2002:a25:2245:0:b0:67b:7758:808b with SMTP id i66-20020a252245000000b0067b7758808bmr23349000ybi.279.1660115357758; Wed, 10 Aug 2022 00:09:17 -0700 (PDT) MIME-Version: 1.0 References: <20220708233233.2554110-1-maskray@google.com> <871qus8cuw.fsf@oldenburg.str.redhat.com> <20220722230837.qea3d33gvji5kxtl@google.com> <8c2e6f15-c08c-9872-3b53-f514ead5692f@redhat.com> <20220804200442.sypcy42jyqmlmoqs@google.com> In-Reply-To: <20220804200442.sypcy42jyqmlmoqs@google.com> From: Fangrui Song Date: Wed, 10 Aug 2022 00:09:06 -0700 Message-ID: Subject: Re: [PATCH] elf.h: Add ELFCOMPRESS_ZSTD To: "Carlos O'Donell" Cc: Adhemerval Zanella Netto , Cary Coutant , Florian Weimer , libc-alpha Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.4 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 07:09:21 -0000 On Thu, Aug 4, 2022 at 1:04 PM Fangrui Song wrote: > > On 2022-07-29, Carlos O'Donell wrote: > >On 7/26/22 16:30, Fangrui Song wrote: > >> On Tue, Jul 26, 2022 at 1:24 PM Adhemerval Zanella Netto > >> wrote: > >>> > >>> > >>> > >>> On 22/07/22 20:08, Fangrui Song via Libc-alpha wrote: > >>>> On 2022-07-18, Carlos O'Donell via Libc-alpha wrote: > >>>>> On 7/11/22 00:58, Florian Weimer via Libc-alpha wrote: > >>>>>> * Fangrui Song via Libc-alpha: > >>>>>> > >>>>>>> I wish that the macro definition can catch up the upcoming > >>>>>>> https://sourceware.org/glibc/wiki/Release/2.36 [1], so that > >>>>>>> projects can expect the value ELFCOMPRESS_ZSTD from elf.h. > >>>>>>> The projects may choose to define the macro themselves, > >>>>>>> but having the definition in an earlier release seems a good idea > >>>>>>> anyway, and it the glibc definition makes it clearer ELFCOMPRESS_ZSTD > >>>>>>> is standard and vendors can start adding support. > >>>>>>> > >>>>>>> [1]: https://sourceware.org/pipermail/libc-alpha/2022-July/140352.html > >>>>>>> ("Release of glibc 2.36 in 1 month! Please add blockers and desirable for release.") > >>>>>> > >>>>>> This looks quite backportable to me, so it should not be a release > >>>>>> blocker. It's only a blocker if we apply the patch today, then we'd > >>>>>> have to wait until the gABI assignment actually happens as expected. > >>>>> > >>>>> Agreed. This is a NACK from me as the RM until the gABI assignment happens. Ping > >>>> > >>>> Cary has accepted this value: https://groups.google.com/g/generic-abi/c/satyPkuMisk/m/KwTF_U8rBAAJ > >>>> (Thanks!) > >>>> > >>>> Ed Maste from FreeBSD wants to define this in FreeBSD. > >>>> > >>>> Shall we define it for glibc as well? :) > >>> > >>> I think this is ok, we are already fixing bad designs so we most likely need > >>> more time for testing. > >> > >> Thanks. Now that it is approved, the commit message can be changed to > >> the following if you want to push it to the 2.36 release branch. > >> > >> elf.h: Add ELFCOMPRESS_ZSTD > >> > >> From the approved generic ABI proposal > >> https://groups.google.com/g/generic-abi/c/satyPkuMisk > >> ("Add new ch_type value: ELFCOMPRESS_ZSTD"). > > > >Cary, > > > >Is there a public repo that I can use to cross-check the glibc value with > >the accepted ELF gABI value? > > > >A public repo would make the process of adding matching constants > >easier because I could review what went into the public repository. > > > >Fangrui, > > > >Just for clarity, I don't consider this a release blocker for 2.36. > > Cary pushed a similar change to binutils-gdb > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=03d0ae791f7dca2006b924e90ee4e4944b848260 > > Cary mentioned it on the musl mailing list > https://www.openwall.com/lists/musl/2022/08/03/3 "Yes, this is officially approved."