From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by sourceware.org (Postfix) with ESMTPS id 3BFBD3857C47 for ; Wed, 27 Oct 2021 02:05:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3BFBD3857C47 Received: by mail-yb1-xb2f.google.com with SMTP id v200so2368201ybe.11 for ; Tue, 26 Oct 2021 19:05:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UCI7uWZ7XOPeCJicp43xwSutSQ/flfk30lV9+pAYspo=; b=qDn1gaAYahBv3UiX3vNvB9kTdYfGUxjgmKtEWFekOil6L+rPsihpdgvZRpsGR1vSjX thODLKPGSxSnaJCSSRews+6sh9BSCx00BlBPgv35Sx0Bagal0ut6qTmyy11fXgfv9V4Q lgRA1bzAxcTxMERI/YrySKlcNTmfEBrI6lzip0fVMIL++0eiV93Pb8UU5sSPXR0DQvak J2CZa0bdPBR6TBEkXDktum9VZm5A5fG2KO9XzHSMkPzgHLPF3kbxdITVCkK8apZ3Shsn IYbdCi1XFb9owsMtxvfzRrHL92oalRZnHVUgZzSiN2JRwmuh9gxw9wYHYgDGHO6udbjO Mj7A== X-Gm-Message-State: AOAM531fLRjFbfOveoIryAeyLfaqvrXQysiauFb50pf1z7/gu6roi7Lh GoHlRm7DqpTj5j1rSCCEy+dJz7172DYlQXClUC//Sg== X-Google-Smtp-Source: ABdhPJwKCvMsJoECY6GJhyJwMxNMG1iYrn7BDxhQHHj8cv/xXOKz5th2lkboZ9OF43y7HwUVFLLZ9o2UIvkKOgTDekg= X-Received: by 2002:a5b:d0b:: with SMTP id y11mr13951558ybp.492.1635300309461; Tue, 26 Oct 2021 19:05:09 -0700 (PDT) MIME-Version: 1.0 References: <20211026200346.3371750-1-adhemerval.zanella@linaro.org> <20211026200346.3371750-4-adhemerval.zanella@linaro.org> In-Reply-To: <20211026200346.3371750-4-adhemerval.zanella@linaro.org> From: =?UTF-8?B?RsSBbmctcnXDrCBTw7JuZw==?= Date: Tue, 26 Oct 2021 19:04:58 -0700 Message-ID: Subject: Re: [PATCH 3/3] Check if linker also support -mtls-dialect=gnu2 To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, "H . J . Lu" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-23.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2021 02:05:14 -0000 On Tue, Oct 26, 2021 at 1:03 PM Adhemerval Zanella wrote: > > Since some linkers (for instance lld for i386) does not support it > for all architectures. > > Checked on i686-linux-gnu. > --- > configure | 4 ++-- > configure.ac | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/configure b/configure > index 2a28c58cd6..c66082232e 100755 > --- a/configure > +++ b/configure > @@ -6324,8 +6324,8 @@ void foo (void) > i = 10; > } > EOF > -if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -S -fPIC -mtls-dialect=gnu2 > - conftest.c 1>&5' > +if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles > + conftest.c -o conftest 1>&5' > { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 > (eval $ac_try) 2>&5 > ac_status=$? > diff --git a/configure.ac b/configure.ac > index 00f49f09f7..7eb4239359 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1493,8 +1493,8 @@ void foo (void) > i = 10; > } > EOF > -if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -S -fPIC -mtls-dialect=gnu2 > - conftest.c 1>&AS_MESSAGE_LOG_FD]) > +if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=gnu2 -nostdlib -nostartfiles > + conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD]) > then > libc_cv_mtls_dialect_gnu2=yes > else > -- > 2.32.0 > Looks good to me. I'll add R_386_TLS_DESC support to LLD with https://reviews.llvm.org/D112582