From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maskray@google.com>
Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com
 [IPv6:2607:f8b0:4864:20::b2e])
 by sourceware.org (Postfix) with ESMTPS id 7F5AB3858C27
 for <libc-alpha@sourceware.org>; Tue, 19 Oct 2021 06:18:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F5AB3858C27
Received: by mail-yb1-xb2e.google.com with SMTP id n65so1589180ybb.7
 for <libc-alpha@sourceware.org>; Mon, 18 Oct 2021 23:18:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to;
 bh=V3DuHnG+ijWI2hrNkdKePowPcsSjHjMsaomTxR8BSyI=;
 b=O15c56cvRLv0q/8Ly/xMBA/Cz24Vq6IF24MzeV3TNx4Rs6jFM7F6bhepJw4Gw8TCuj
 tCVmvxOd0XFRgYSXXvJQ/q23rsZB6YfcGwSgPIURoG3ftlThsVLuqIOPLdu9L+GLdEvC
 kAZtQN/0GvHMul+jQXoTIezSWnxJfuQAW2XWv/xz2oQY8btnXMwosPCCd59pfzRmFhKM
 7t7NzE3iAzCl1U6tv3hVk4XeU76ibtTX5alHHyUyuEV0hvlaTg9peXhrhsN2jfXOQkc0
 XUo+mRaMmQgVL+vvqxIel4vswLoYZoA+c1Wb8xOp/PGspjlII9EZZNkl+I8RhpmlwUMw
 4DKQ==
X-Gm-Message-State: AOAM533P6jn17TXVUnU57Wg/43c0UkGOqzNGGoDMxL4J3usDbLVHeuMI
 u6r0NEPImrL7srJXEfJRCB0I1mP4qWXAAKdKjqKwV9N3hj0=
X-Google-Smtp-Source: ABdhPJxM2A2KI8U57jQYbxvNiX7mGXFJw9im1z2GWiqFQ1WbQrlklBWXoP7QSGzPJxqFTDq0FrXgvNSPLKqM3fTOY7g=
X-Received: by 2002:a25:d06:: with SMTP id 6mr32365918ybn.519.1634624332761;
 Mon, 18 Oct 2021 23:18:52 -0700 (PDT)
MIME-Version: 1.0
References: <20211008014014.800723-1-maskray@google.com>
 <20211015162935.a7sqpxrgk7lxhrix@google.com>
In-Reply-To: <20211015162935.a7sqpxrgk7lxhrix@google.com>
From: =?UTF-8?B?RsSBbmctcnXDrCBTw7JuZw==?= <maskray@google.com>
Date: Mon, 18 Oct 2021 23:18:41 -0700
Message-ID: <CAFP8O3+jcNS0KcCUP3FZQ8ws1EUw_iSO+ecJNDn6c1hZ49ua+A@mail.gmail.com>
Subject: Re: [PATCH] glibcextract.py: Place un-assemblable @@@ in a comment
To: libc-alpha@sourceware.org, Joseph Myers <joseph@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-24.3 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Oct 2021 06:18:54 -0000

On Fri, Oct 15, 2021 at 9:29 AM Fangrui Song <maskray@google.com> wrote:
>
> On 2021-10-07, Fangrui Song wrote:
> >Unlike GCC, Clang passes asm statements and verifies they are valid
> >instructions/directives. Place the magic @@@ into a comment to avoid
> >a parse error.
> >---
> > scripts/glibcextract.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/scripts/glibcextract.py b/scripts/glibcextract.py
> >index 752ff6223b..bf49a5e322 100644
> >--- a/scripts/glibcextract.py
> >+++ b/scripts/glibcextract.py
> >@@ -45,7 +45,7 @@ def compute_c_consts(sym_data, cc):
> >             continue
> >         name = arg[0]
> >         value = arg[1]
> >-        out_lines.append('asm ("@@@name@@@%s@@@value@@@%%0@@@end@@@" '
> >+        out_lines.append('asm ("/* @@@name@@@%s@@@value@@@%%0@@@end@@@ */" '
> >                          ': : \"i\" ((long int) (%s)));'
> >                          % (name, value))
> >     out_lines.append('}')
> >--
> >2.33.0.882.g93a45727a2-goog
> >
>
> Ping..

This seems trivial and straightforward. I'll give a few days and then push it.