From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by sourceware.org (Postfix) with ESMTPS id 5C3C03858C56 for ; Tue, 26 Jul 2022 20:30:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C3C03858C56 Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-31f1d1c82c8so62025837b3.8 for ; Tue, 26 Jul 2022 13:30:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n8QO7KMy1oIJuTrHsX90y9Ocy0APzXPrBFeeQxbkPtU=; b=ZY8+4VUwzw27VnSNyEoLvnyVUEumfFL/Qt5UPEWHBZoiVkERX1aGamUFegvd+OFiGc aCStOdnmmXx0xkQs4kTsKwTvfTc1beRpGzpg4AeZQ9tPHiT9Q9CRqaKhNqH7dPvm3gL1 H5GAoovdD4T4rvOMZmmY/7tDQZDsNhEcfL0XVtbqX+25yT2d14yUmN9D+BrnFXkg1u1W q6J7qM8oG4NUiEDBxUtEIISCDSg5nqdKj/GMth8k5YecQzKdEibVxTw1xWPMR5AfrUxC Y4LE4tZ0uQcrvXXe1oW3toGECUmF21trDK82y3Jk/wtFteM5JiOiBz7uaNxd5ejxHQgV hiWg== X-Gm-Message-State: AJIora+rVZk4DeGJ24O3VT07MwZn/DybODNyceIC231f+PHpd6X4TpkJ UKY1ngjaYdMP8aJwpfY7HdenXnkmLqhOtFvuZp0i9Q== X-Google-Smtp-Source: AGRyM1uBzuc2exD6ujI4/rgSZMgCjuTzOqIQFFE5F+oxi60qRLPAs29IS+uwB/eZVYgmPnOYeXlm+MYXuSa2K2VrS0Q= X-Received: by 2002:a0d:d597:0:b0:31f:5858:9050 with SMTP id x145-20020a0dd597000000b0031f58589050mr2258077ywd.341.1658867445392; Tue, 26 Jul 2022 13:30:45 -0700 (PDT) MIME-Version: 1.0 References: <20220708233233.2554110-1-maskray@google.com> <871qus8cuw.fsf@oldenburg.str.redhat.com> <20220722230837.qea3d33gvji5kxtl@google.com> In-Reply-To: From: Fangrui Song Date: Tue, 26 Jul 2022 13:30:34 -0700 Message-ID: Subject: Re: [PATCH] elf.h: Add ELFCOMPRESS_ZSTD To: Adhemerval Zanella Netto Cc: "Carlos O'Donell" , Florian Weimer , Cary Coutant , Fangrui Song via Libc-alpha Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2022 20:30:48 -0000 On Tue, Jul 26, 2022 at 1:24 PM Adhemerval Zanella Netto wrote: > > > > On 22/07/22 20:08, Fangrui Song via Libc-alpha wrote: > > On 2022-07-18, Carlos O'Donell via Libc-alpha wrote: > >> On 7/11/22 00:58, Florian Weimer via Libc-alpha wrote: > >>> * Fangrui Song via Libc-alpha: > >>> > >>>> I wish that the macro definition can catch up the upcoming > >>>> https://sourceware.org/glibc/wiki/Release/2.36 [1], so that > >>>> projects can expect the value ELFCOMPRESS_ZSTD from elf.h. > >>>> The projects may choose to define the macro themselves, > >>>> but having the definition in an earlier release seems a good idea > >>>> anyway, and it the glibc definition makes it clearer ELFCOMPRESS_ZSTD > >>>> is standard and vendors can start adding support. > >>>> > >>>> [1]: https://sourceware.org/pipermail/libc-alpha/2022-July/140352.html > >>>> ("Release of glibc 2.36 in 1 month! Please add blockers and desirable for release.") > >>> > >>> This looks quite backportable to me, so it should not be a release > >>> blocker. It's only a blocker if we apply the patch today, then we'd > >>> have to wait until the gABI assignment actually happens as expected. > >> > >> Agreed. This is a NACK from me as the RM until the gABI assignment happens. > >> > > > > Cary has accepted this value: https://groups.google.com/g/generic-abi/c/satyPkuMisk/m/KwTF_U8rBAAJ > > (Thanks!) > > > > Ed Maste from FreeBSD wants to define this in FreeBSD. > > > > Shall we define it for glibc as well? :) > > I think this is ok, we are already fixing bad designs so we most likely need > more time for testing. Thanks. Now that it is approved, the commit message can be changed to the following if you want to push it to the 2.36 release branch. elf.h: Add ELFCOMPRESS_ZSTD >From the approved generic ABI proposal https://groups.google.com/g/generic-abi/c/satyPkuMisk ("Add new ch_type value: ELFCOMPRESS_ZSTD").