From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 7B81B3858D28 for ; Sat, 27 Jan 2024 01:14:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B81B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B81B3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706318088; cv=none; b=wuw14Xl5jMnnBR36HLHuIddk40xVH+LucL9eJws8wlTCHiBlq0Rs4S42DSZIBVbv3i2DMzRoGwvpV1uhXeQmCWDp0QWUAEojtFh8e7tFW5MSRH9RUf6TBuPRFT6F9eKauD7MUPp1CRp5xWYTHaKKmExjFrYq6u21CCToyg/22Ms= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706318088; c=relaxed/simple; bh=+9VTMvu4UpeRrKEf/YbZaCyI60XHz2MbeztOP1joxEs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=lYg8X4y26RUO/MstsEVP3DI8xAwYdgvr5ZrH+V3YxShD63T7uww2mB1Xi9O4c1mFq5NnblUO4IEtWpBKa77wJM6ahLjVganFAC9HUJ6e92M+qd5h60BJsYyj6+HOYQ/fn1ZxoQ4CcUpk5tum3hwWl4aTYP0F4qjevPm2YXSqWf8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40e4afe9ea7so8755e9.1 for ; Fri, 26 Jan 2024 17:14:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706318080; x=1706922880; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ON0uD/81jf/AV2Mm1a+0T1j8pXB2tgtOpZeNkrMnN/c=; b=QoushD4jmIjoUG68/Eal7MTPNEhHfkX7nzrZRANwLKilhjKX4qRPFEh7SpWBm2RvdS rBDKg+BFxG7eDzSoRvdEj6EYzVe2a8ezUFV8mjjc2GBQYb7KnHF85E3PoGf+zM/NqBOE PzKsz+vkwxRYMlXyTkfAFtMKq3arc0HZre1pv0iVAirhAVJRxipJnmpNlAWTDKVKWczh NEnWWS8YmpJIxgEhP8vAAC+PDiMpx3BI2dQzBPZx+HJX61+1dL84guDNwx4GgwWC/WEy PmTko+YYbxW/1qMxuhSsWXHvA+KoJnEgrI+lfkP5p+yiqMT93psJC8ONAhW9Rj/J7Wlc SPuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706318080; x=1706922880; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ON0uD/81jf/AV2Mm1a+0T1j8pXB2tgtOpZeNkrMnN/c=; b=I2Q0UJbmmwDfVmJoglyQIP4OGMVb4CaNUDFIh+PyBR9vc8ranotDRnDqTYpTDs0QV0 i3r4goJsi3jgxPZ6ZUNbvxOjcWiCV0RKliGKVEqL0SO37T5VaSZf8IHr5qLqtAE3sE6t y1XNc7Gr2MAYJy3HkysGmNwjxG7kRnlQ16u1/o3/KrGaTzpFccrXvFY6SmEhcSI2YSbb uiAEFBTMf7r4gZlriQRmJZGu4jIDUULbN5luyszDjpoUz39w5p4fM7Eml5i1yRsf7qKV cnYWq1shR6rgXyebPOQkRwZRWaE6esKyNzdb3819lToHflG7O4KJR3V61dXFOrP4dtpM SJtg== X-Gm-Message-State: AOJu0YyedcB/766RH9TmcRM6q3D12iSwXeaK1WcOQDK0ORer09aBOtp7 yKSNb8d1wImQQlsih6r98+40yHMAZT0Yp3+Tr7Sdqwtr6bSVj+T6ENd609i9nU2vZJvRlhFejs1 YUQgFuqwpDiejliACZEVaJL3ZKku68/jgMksI X-Google-Smtp-Source: AGHT+IGtA/yeK+lZkW10OGqmvmcu7vNJ4q6f3++BO0hR8oSHwdTxZUHuV0ZWtXUCvRJ0KvVyXz9Rk411ZAM0Zxz2vtk= X-Received: by 2002:a05:600c:354e:b0:40e:a281:10f9 with SMTP id i14-20020a05600c354e00b0040ea28110f9mr258412wmq.2.1706318080138; Fri, 26 Jan 2024 17:14:40 -0800 (PST) MIME-Version: 1.0 References: <20230817181228.122674-2-ishitatsuyuki@gmail.com> <20230914084033.222120-1-ishitatsuyuki@gmail.com> <20230914084033.222120-2-ishitatsuyuki@gmail.com> In-Reply-To: <20230914084033.222120-2-ishitatsuyuki@gmail.com> From: Fangrui Song Date: Fri, 26 Jan 2024 17:14:26 -0800 Message-ID: Subject: Re: [PATCH v4 1/3] RISC-V: Add include guard for dl-tls.h. To: Tatsuyuki Ishi Cc: libc-alpha@sourceware.org, rui314@gmail.com, ruiu@bluewhale.systems, schwab@linux-m68k.org, adhemerval.zanella@linaro.org, andrew@sifive.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-23.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Sep 14, 2023 at 1:41=E2=80=AFAM Tatsuyuki Ishi wrote: > > --- > sysdeps/riscv/dl-tls.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sysdeps/riscv/dl-tls.h b/sysdeps/riscv/dl-tls.h > index 67c8ae639c..f11f335edf 100644 > --- a/sysdeps/riscv/dl-tls.h > +++ b/sysdeps/riscv/dl-tls.h > @@ -16,6 +16,8 @@ > License along with the GNU C Library. If not, see > . */ > > +#ifndef _DL_TLS_H > +# define _DL_TLS_H 1 > > /* Type used for the representation of TLS information in the GOT. */ > typedef struct > @@ -46,3 +48,5 @@ extern void *__tls_get_addr (tls_index *ti); > > /* Value used for dtv entries for which the allocation is delayed. */ > #define TLS_DTV_UNALLOCATED ((void *) -1l) > + > +#endif /* _DL_TLS_H */ > -- > 2.42.0 > This commit message should state why the header is needed. Multiple sysdeps/*/dl-tls.h do not have a guard and they are good. --=20 =E5=AE=8B=E6=96=B9=E7=9D=BF