From: Fangrui Song <maskray@google.com>
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: samuel.thibault@ens-lyon.org, libc-alpha@sourceware.org,
vincent.chen@sifive.com
Subject: Re: error: macro DT/STO_RISCV_VARIANT_CC redefined
Date: Mon, 1 May 2023 20:46:43 -0700 [thread overview]
Message-ID: <CAFP8O3Kh0YP0oqSyo3L=vd6vK4QhBzX4tkAR7APwdhbO6TgRLg@mail.gmail.com> (raw)
In-Reply-To: <mhng-5f9455e8-89c6-483a-b8d0-df51dfe43638@palmer-ri-x1c9a>
On Mon, May 1, 2023 at 5:42 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> On Mon, 01 May 2023 01:42:08 PDT (-0700), samuel.thibault@ens-lyon.org wrote:
> > Also, the kai.wang@sifive.com email address doesn't seem to be working,
> > the mail server says it doesn't exist...
>
> Sorry, it's my fault -- I committed it thinking the test suite had been
> run, but it hadn't. I've got some WIP, but I found another test suite
> hook I need last night and I've yet to make sure that's enough as my
> test box went down.
>
> I think we should just go ahead and commit the revert for now? That way
> we can avoid having other folks be broken while I figure out what's up.
I agree that committing a revert for
117e8b341c5c0ace8d65feeef136fececb3fdc9c will be cleaner.
Then you may push another commit adding the macros to a conventional
location, avoiding the duplicate.
Then some of the patches in "[PATCH v3 0/6] elf.h: Fix and cleanup the
RISC-V defines" can be avoided.
> >
> > Samuel Thibault, le lun. 01 mai 2023 10:40:30 +0200, a ecrit:
> >> Hello,
> >>
> >> I'm getting these errors:
> >>
> >> FAIL: elf/tst-relro-ldso
> >> FAIL: elf/tst-relro-libc
> >> FAIL: elf/tst-glibcelf
> >>
> >> /mnt/scratch/sthibault/build-glibc/src/glibc/scripts/../elf/elf.h:4013: error: macro STO_RISCV_VARIANT_CC redefined
> >> /mnt/scratch/sthibault/build-glibc/src/glibc/scripts/../elf/elf.h:3941: note: location of previous definition
> >> /mnt/scratch/sthibault/build-glibc/src/glibc/scripts/../elf/elf.h:4023: error: macro DT_RISCV_VARIANT_CC redefined
> >> /mnt/scratch/sthibault/build-glibc/src/glibc/scripts/../elf/elf.h:3937: note: location of previous definition
> >> Traceback (most recent call last):
> >> File "/mnt/scratch/sthibault/build-glibc/src/glibc/elf/tst-relro-symbols.py", line 33, in <module>
> >> import glibcelf
> >> File "/mnt/scratch/sthibault/build-glibc/src/glibc/elf/../scripts/glibcelf.py", line 226, in <module>
> >> _elf_h = _parse_elf_h()
> >> File "/mnt/scratch/sthibault/build-glibc/src/glibc/elf/../scripts/glibcelf.py", line 223, in _parse_elf_h
> >> raise IOError('parse error in elf.h')
> >> OSError: parse error in elf.h
> >>
> >> and indeed, elf/elf.h defines STO_RISCV_VARIANT_CC and
> >> DT_RISCV_VARIANT_CC twice.
> >>
> >> This seems to have been introduced by 117e8b341c5c ("riscv: Resolve
> >> symbols directly for symbols with STO_RISCV_VARIANT_CC.")?
> >>
> >> Samuel
--
宋方睿
next prev parent reply other threads:[~2023-05-02 3:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 8:40 Samuel Thibault
2023-05-01 8:42 ` Samuel Thibault
2023-05-01 12:42 ` Palmer Dabbelt
2023-05-02 3:46 ` Fangrui Song [this message]
2023-05-07 3:11 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFP8O3Kh0YP0oqSyo3L=vd6vK4QhBzX4tkAR7APwdhbO6TgRLg@mail.gmail.com' \
--to=maskray@google.com \
--cc=libc-alpha@sourceware.org \
--cc=palmer@rivosinc.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=vincent.chen@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).