From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maskray@google.com>
Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com
 [IPv6:2607:f8b0:4864:20::b2f])
 by sourceware.org (Postfix) with ESMTPS id 5635B3858405
 for <libc-alpha@sourceware.org>; Fri, 29 Oct 2021 00:56:55 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5635B3858405
Received: by mail-yb1-xb2f.google.com with SMTP id a129so6830675yba.10
 for <libc-alpha@sourceware.org>; Thu, 28 Oct 2021 17:56:55 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=BzerUW02U8+6HcDJUhM0LHL8Yy4azFJ0PXAzYyHLEQM=;
 b=bD2ldt9XV9/+ZJZEasg/vnQQAkONsNfTDPM+GZqsFexGl3b0LPfTaa98nN+PzWm5ef
 Mz1EGQEMi8FeNjZsPFOnHrvH7r34DebSxS05OdboTd36wb0k8Xk6w9Zqk07+/O09UHJC
 abbwzg+afz2YQ7FoyxMSXthNCCBbpIItCTPtDYAFoScSAHoUezD5PeKeMNdBPsP0h+iG
 1GuOTAW6HBKJiXX+YXP5lKQDQoPEzMeDKNJVskd61/dWapRam8I1Gvx5ZOi49FBExDvs
 uRdqeSFDYHOZhUe3TB/epsJlmvU+34a6xHk+MLTf0CTVdwpqyBWbI/li5CnzUsIS2qBf
 Z+yA==
X-Gm-Message-State: AOAM531LjFBnmU86UCub5r2aY3Dd/wB3bW/t9mvg9T67549sLPeuo/SP
 S0Aftzj+sN+g41DKvvzJ8dbAv1Cxe1jydpbGyjmX4w==
X-Google-Smtp-Source: ABdhPJwn+eee590r9KqS7ZVrngv50qgitpB2jw1i0ZqsdtpauZW4E+zxPBjXeChcotZq0as3SKqxsMWE0fjZ5l3kBHo=
X-Received: by 2002:a5b:d0b:: with SMTP id y11mr8350225ybp.492.1635469014633; 
 Thu, 28 Oct 2021 17:56:54 -0700 (PDT)
MIME-Version: 1.0
References: <20211026200346.3371750-1-adhemerval.zanella@linaro.org>
 <20211026200346.3371750-4-adhemerval.zanella@linaro.org>
 <CAFP8O3+VPsfF8wdvWpUR4Q+JU4faFsLnSEBDnPVWjaB7wVABYQ@mail.gmail.com>
In-Reply-To: <CAFP8O3+VPsfF8wdvWpUR4Q+JU4faFsLnSEBDnPVWjaB7wVABYQ@mail.gmail.com>
From: =?UTF-8?B?RsSBbmctcnXDrCBTw7JuZw==?= <maskray@google.com>
Date: Thu, 28 Oct 2021 17:56:42 -0700
Message-ID: <CAFP8O3LCX-A1Yu8N9ViudOEKg9JuHt8P2=xO9L-2_W5sawcvOg@mail.gmail.com>
Subject: Re: [PATCH 3/3] Check if linker also support -mtls-dialect=gnu2
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, "H . J . Lu" <hjl.tools@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-23.8 required=5.0 tests=BAYES_00, DKIMWL_WL_MED,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,
 GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP, USER_IN_DEF_DKIM_WL,
 USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Oct 2021 00:56:59 -0000

On Tue, Oct 26, 2021 at 7:04 PM F=C4=81ng-ru=C3=AC S=C3=B2ng <maskray@googl=
e.com> wrote:
>
> On Tue, Oct 26, 2021 at 1:03 PM Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
> >
> > Since some linkers (for instance lld for i386) does not support it
> > for all architectures.
> >
> > Checked on i686-linux-gnu.
> > ---
> >  configure    | 4 ++--
> >  configure.ac | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 2a28c58cd6..c66082232e 100755
> > --- a/configure
> > +++ b/configure
> > @@ -6324,8 +6324,8 @@ void foo (void)
> >    i =3D 10;
> >  }
> >  EOF
> > -if { ac_try=3D'${CC-cc} $CFLAGS $CPPFLAGS -S -fPIC -mtls-dialect=3Dgnu=
2
> > -                  conftest.c 1>&5'
> > +if { ac_try=3D'${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=3Dgnu2 -=
nostdlib -nostartfiles
> > +                  conftest.c -o conftest 1>&5'
> >    { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
> >    (eval $ac_try) 2>&5
> >    ac_status=3D$?
> > diff --git a/configure.ac b/configure.ac
> > index 00f49f09f7..7eb4239359 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -1493,8 +1493,8 @@ void foo (void)
> >    i =3D 10;
> >  }
> >  EOF
> > -if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -S -fPIC -mtls-dialect=
=3Dgnu2
> > -                  conftest.c 1>&AS_MESSAGE_LOG_FD])
> > +if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS -fPIC -mtls-dialect=3Dgn=
u2 -nostdlib -nostartfiles
> > +                  conftest.c -o conftest 1>&AS_MESSAGE_LOG_FD])
> >  then
> >    libc_cv_mtls_dialect_gnu2=3Dyes
> >  else
> > --
> > 2.32.0
> >
>
> Looks good to me.
>
> I'll add R_386_TLS_DESC support to LLD with https://reviews.llvm.org/D112=
582

Reviewed-by: Fangrui Song <maskray@google.com>

I pushed https://reviews.llvm.org/D112582 as a maintainer of lld/ELF.

You can say that LLD before 14 did not support x86-32 TLSDESC.