From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id C3873385042C for ; Fri, 8 Jan 2021 05:04:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C3873385042C Received: by mail-pl1-x633.google.com with SMTP id x12so5049552plr.10 for ; Thu, 07 Jan 2021 21:04:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=A0cr1ITRS45lzaWsmfOzFqBWGvtSu+6tkW2TcErUis0=; b=mGcQNTSPzMNARx/Xho8+5UZq5f0NA9c7zYza2ub4ABn6phpJMK+8u8snl2hw7hyDUu x3L99xHvhbmAzGBWbMt0oblUOWtP3Tcl2vcYbTUuMc9jU08o4/U1ZrInu+zsM+g/K+9e v/nYr1N8XMtQlIRjpw0Y8NN5HCaIn1U1YjbgiKeaigqZbjIznBe/HbjLgWr2bSxtISSH EJ7hIy+3F7lJLS/bdiIf3s+ysxlD4/mcZ0hmpq8jZHt5GqR/otkikAanUDNpftv5LPuK OlhYxLG4zyOOB9hzCLqoIhpEVEgCuqkkB9NnYrqDhCBzwsfc2YcSRqNO5lZyt3YEz6OS qocA== X-Gm-Message-State: AOAM5330fmw0OLECtTHrdScEbhC2Kbvc8xdJwRu/EqBdd+fRFRpfxP4p zyoaxVVYZJhJE/JPVUAeul4Go/6aVUkqmg/QxX39MhZU6X0yKg== X-Google-Smtp-Source: ABdhPJy8l1a8thQudMjw8yH2RrtjMq951c6nIs4AfxKpg4WgsTlghC3Bu9h8lAJZ9pmohw1k646Ma3Erk4XQS7UqI3s= X-Received: by 2002:a17:90a:1748:: with SMTP id 8mr1905798pjm.47.1610082288361; Thu, 07 Jan 2021 21:04:48 -0800 (PST) MIME-Version: 1.0 References: <20201228194855.510315-1-maskray@google.com> In-Reply-To: <20201228194855.510315-1-maskray@google.com> From: =?UTF-8?B?RsSBbmctcnXDrCBTw7JuZw==?= Date: Thu, 7 Jan 2021 21:04:37 -0800 Message-ID: Subject: Re: [PATCH 0/3] Make glibc build with LLD To: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 05:04:54 -0000 On Mon, Dec 28, 2020 at 11:48 AM Fangrui Song wrote: > > I sent the first two in April. Resending in a patch series to be > clearer. > > install: Replace scripts/output-format.sed with objdump -f > > replaced https://sourceware.org/pipermail/libc-alpha/2020-April/112733.html > by leveraging objdump -f. > > With this patch series (available in https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/maskray/lld), > `make` with ld pointing to ld.lld (LLVM linker) works. > > Fangrui Song (3): > configure: Allow LD to be a linker other than GNU ld and gold > elf: Replace a --defsym trick with an object file to be compatible > with lld > install: Replace scripts/output-format.sed with objdump -f > > Makerules | 13 ++----- > .../strcoll-inputs/filelist#en_US.UTF-8 | 1 - > config.make.in | 1 - > configure | 32 +++++------------ > configure.ac | 24 +++++-------- > elf/Makefile | 11 +++--- > scripts/output-format.sed | 35 ------------------- > 7 files changed, 23 insertions(+), 94 deletions(-) > delete mode 100644 scripts/output-format.sed > > -- > 2.29.2.729.g45daf8777d-goog > Hope "elf:" and "install:" can be reviewed (they are nice simplification on their own), even if you don't want to take "configure:" for now. For __rela_iplt_start, I gave a fair assessment on https://bugs.llvm.org/show_bug.cgi?id=48674#c4 . I feel bad that an improvable binutils issue caused the block of a static-pie relocation improvement "Make _dl_relocate_static_pie return an int indicating whether it applied relocs." The other few failures (e.g. not supporting ld.lld --audit / tls common) are not really usability affecting issues.