From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by sourceware.org (Postfix) with ESMTPS id 7E07F3858407 for ; Thu, 4 Aug 2022 21:31:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E07F3858407 Received: by mail-yb1-xb2f.google.com with SMTP id j63so1034590ybb.13 for ; Thu, 04 Aug 2022 14:31:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=fH9voIv/R/4IwCIGwE2nitIOUm+zNgMLgKq2dDYqhmU=; b=1wjzc+UxR/nPG/kf+bcfnSHZQOev9X8jorbgBdb43grKPAxy0n2k6VjZsJLfllXRGA 7mgx7GaZY698GqoRNWJyeT2DB9GNkX2NpVmLHgSbBBoJUGKRJLOzY34wH9V+cJSx/3Sp Jjt4548o3KWJRnobmMj2OQ0qDpEB0u+w7jaD62rx0FI2cN+swZKT7k3oLXY9UEUOA2K7 /7UNV3tyqQuPotR5qdVCzwHiQJ4TrzJ/nn9pumayXzzfoH+Zyi2H8wDVmGwZEdmOdVWr oVUKCifGTTGHmh5nL5Vm9Nr710kXbgnCQ3kSgLI6bQIkqGfVwtH3YfAmaY6p1SPKfNtn Itew== X-Gm-Message-State: ACgBeo31kcyLIAGjnp6vYJbGGMuxT/PuayaxP0sdwgOeAJhAiLXcYU1Y VSzVhEDgIUJ5d0E4L4vreuUJqBNQUvoWGaBP4qud9Q== X-Google-Smtp-Source: AA6agR7j+DFZDsDL84EL21DvMSxanc7ECnJesGnzJIDz2hEeT/qvquIhX785IDRD+6kBGYxVdG7hgU35EQoGP+6elPM= X-Received: by 2002:a25:2417:0:b0:675:a9b2:dad0 with SMTP id k23-20020a252417000000b00675a9b2dad0mr2877235ybk.489.1659648684689; Thu, 04 Aug 2022 14:31:24 -0700 (PDT) MIME-Version: 1.0 References: <20220804210016.2613403-1-adhemerval.zanella@linaro.org> In-Reply-To: From: Fangrui Song Date: Thu, 4 Aug 2022 14:31:13 -0700 Message-ID: Subject: Re: [PATCH] i386: Use fldt instead of fld on e_logl.S To: "H.J. Lu" Cc: Adhemerval Zanella , GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-24.1 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2022 21:31:27 -0000 On Thu, Aug 4, 2022 at 2:24 PM H.J. Lu wrote: > > On Thu, Aug 4, 2022 at 2:00 PM Adhemerval Zanella > wrote: > > > > Clang cannot assemble fldt in the AT&T dialect mode. > > --- > > sysdeps/i386/i686/fpu/e_logl.S | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/sysdeps/i386/i686/fpu/e_logl.S b/sysdeps/i386/i686/fpu/e_logl.S > > index 63183ac544..5d53f3bb22 100644 > > --- a/sysdeps/i386/i686/fpu/e_logl.S > > +++ b/sysdeps/i386/i686/fpu/e_logl.S > > @@ -43,7 +43,7 @@ ENTRY(__ieee754_logl) > > fsubl MO(one) // x-1 : x : log(2) > > 5: fld %st // x-1 : x-1 : x : log(2) > > fabs // |x-1| : x-1 : x : log(2) > > - fld MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > > + fldt MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > > fcomip %st(1) // |x-1| : x-1 : x : log(2) > > fstp %st(0) // x-1 : x : log(2) > > jc 2f > > @@ -76,7 +76,7 @@ ENTRY(__logl_finite) > > fsubl MO(one) // x-1 : x : log(2) > > fld %st // x-1 : x-1 : x : log(2) > > fabs // |x-1| : x-1 : x : log(2) > > - fld MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > > + fldt MO(limit) // 0.29 : |x-1| : x-1 : x : log(2) > > fcomip %st(1) // |x-1| : x-1 : x : log(2) > > fstp %st(0) // x-1 : x : log(2) > > jc 2b > > -- > > 2.34.1 > > > > I don't think this is correct since there are > > .type limit,@object > limit: .double 0.29 > > It should be fldl. > > -- > H.J. If I am not mistaken, the existing fld has a bug as it is treated as flds fld limit@GOTOFF(%edx) # treated as flds flds limit@GOTOFF(%edx) fldl limit@GOTOFF(%edx) fldt limit@GOTOFF(%edx) .section .rodata.cst8,"aM",@progbits,8 .p2align 3 limit: .double 0.29