From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-99450-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 62539 invoked by alias); 20 Jan 2019 18:22:02 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 62413 invoked by uid 89); 20 Jan 2019 18:22:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Attached
X-HELO: mail-io1-f45.google.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=8Mo8L97CgLojvCzw72PQWi6OYwER6VN8AbuuDN27z20=;
        b=roKlnd3VrcAwEWejhroKrjb9tS3vTvMQMGRikdMeCoB232sCyQ+LaTK9iCHsVea4+B
         G7qihZidmgj2iwWUi96XP0ieku0nEz64QFspVmiFWtHHBawaWhUSH6hLCb0d2uEiu3vK
         oWh7YfY559C4eBCNoyfPGAZFkfHi4PT41Owy32iEAaD5yp+ZRUOpYWfvUW/eomD9WSIs
         iC3OcVQhMhsbqZf98PRJK5r0T1rmwCTvOrbSZUo+mVRORMELHZynmfF/V+Qei8/66evd
         tY+KnDn9//ckQpfpSsRcWa2bDzsXBk8tWwlueCf2Io57AFrcLfMmASrURSmx/P+zFhiL
         UCXA==
MIME-Version: 1.0
References: <CAFULd4ZzARNW3Z-XEVbpG9KS6-PY0nzzfzFs3iOHJ9fADsWU0w@mail.gmail.com>
In-Reply-To: <CAFULd4ZzARNW3Z-XEVbpG9KS6-PY0nzzfzFs3iOHJ9fADsWU0w@mail.gmail.com>
From: Uros Bizjak <ubizjak@gmail.com>
Date: Sun, 20 Jan 2019 18:22:00 -0000
Message-ID: <CAFULd4a6Fh8MDGOh_30DnVSM0yUBj18nMhvAcrF6FdyWJU6ABg@mail.gmail.com>
Subject: Re: [PATCH, alpha]: Fix sysdeps/alpha/remqu.S clobbering $f3 reg
To: libc-alpha@sourceware.org
Cc: Richard Henderson <rth@twiddle.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2019-01/txt/msg00520.txt.bz2

On Fri, Jan 18, 2019 at 2:06 PM Uros Bizjak <ubizjak@gmail.com>
wrote:Please also find the missing ChangeLog entry.

Please find missing ChangeLog entry in this message. Also, please note
I don't have write access to glibc repository.

Uros.

> Attached patch fixes sysdeps/alpha/remqu.S clobbering $f3 register via
> $y_is_neg path. There was missing restore of $f3 before the return
> from the function.
>
> The patch also reorders insns a bit, so it becomes similar as much as
> possible to divqu.S.
>
> Without the patch, math/big testcase from Go-1.11 testsuite (that
> includes lots of corner cases that exercise remqu) FAIL, with patched
> function, the testcase PASSes without problems.

2019-18-01  Uro=C5=A1 Bizjak  <ubizjak@gmail.com>

    * sysdeps/alpha/remqu.S (__remqu): Add missing restore
    of $f3 register on $y_is_neg path.  Reorder instructions
    similar to divqu.S order.

> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
>
> Uros.