From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 910A93858437 for ; Mon, 27 Sep 2021 21:06:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 910A93858437 Received: by mail-pj1-x1031.google.com with SMTP id nn5-20020a17090b38c500b0019af1c4b31fso1083995pjb.3 for ; Mon, 27 Sep 2021 14:06:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mn0k64ZPMnxeLRzinIL8/+jP9RhOc38GayERp5r/MvQ=; b=3q3ePu0VPuKF8VAOdbclASU+SWw1bPllBOfI/But10cJsNIQlvnxD7l8mVf+x4uFfG RDEZQtQ9hLJImEbKn7LLSSd2Z93n8IP/WPiadfLe5rRVHom5GwXiNayYbiHfgmvUWTu1 ghUMxEio5LcQ8Tjh8bvbPFeN+xsGHcbRYW4VvzCQjJ1mf5k6qmfdWJXXQruvyhT82MIE EKN6WlRNrN3HUKr+Qf9l3Iu/RGB75vBSEqpub/wrtnkcnZ+GVN/S3AjGlx++f6V6/vcu s/hgk2UVTOu/yDaWCEhfWXHsBSfic2ySGI2raTB6dFfuofafDx9rQnIhBCDvIql1mLC5 b0ZQ== X-Gm-Message-State: AOAM531gWHTQLO38E9D7jNRWgK1xF92JacSA+/XahItRPFhWCVinBPPv rpU3je/r8SwyGvOFrdHfr2CejMgkT03sq2wKss8= X-Google-Smtp-Source: ABdhPJyU/Bt9L8cDC6GDmTQCp05Tg+8/FKqJJm3pCu2EQe8c/dBV2DN/WdP+yB014P03HCLlpFEnN+cOaC0yeY+yNG0= X-Received: by 2002:a17:90a:c914:: with SMTP id v20mr1262530pjt.208.1632776802586; Mon, 27 Sep 2021 14:06:42 -0700 (PDT) MIME-Version: 1.0 References: <20210927203827.2852935-1-goldstein.w.n@gmail.com> In-Reply-To: From: Noah Goldstein Date: Mon, 27 Sep 2021 16:06:31 -0500 Message-ID: Subject: Re: [PATCH v1] String: Add support for __memcmpeq() ABI on all targets To: Joseph Myers Cc: GNU C Library Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2021 21:06:44 -0000 On Mon, Sep 27, 2021 at 3:43 PM Joseph Myers wrote: > > On Mon, 27 Sep 2021, Noah Goldstein via Libc-alpha wrote: > > > +/* Compare N bytes of S1 and S2. Return zero if S1 and S2 are equals. Return > > + some non-zero value otherwise. > > + > > + Essentially the exact same semantics as memcmp() except the return > > + value is less constrained. memcmp() is always a correct > > + implementation of __memcmpeq(). As well !!memcmp(), -memcmp(), or > > + bcmp() are correct implementations. > > + > > + Used by compilers when memcmp() return is only used for its bolean > > + value. */ > > GNU standards say not to use () after a function name to indicate that > it's a function, only when you actually want a function call with no > arguments. Also, two spaces after '.' at end of sentence. Fixed. > > > +GLIBC_3.5 __memcmpeq F > > That's the wrong version. > > > +GLIBC_3.5 __memcmpeq F > > \ No newline at end of file > > Likewise, and these files should all end with a newline. Fixed. > > -- > Joseph S. Myers > joseph@codesourcery.com